Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Hide Copy to clipboard for IOU comments #7045

Merged
merged 1 commit into from
Jan 5, 2022
Merged

fix: Hide Copy to clipboard for IOU comments #7045

merged 1 commit into from
Jan 5, 2022

Conversation

mananjadhav
Copy link
Collaborator

Details

  • Hide Copy to clipboard action for IOU transactions

Fixed Issues

$ #7009

Tests

  1. Tested for all IOU transactions (self and the other party)

QA Steps

  1. Go to any chat list with IOU transactions
  2. Right-click on Web/Desktop (and long press on mobile) on any IOU transaction
  3. Copy to clipboard shouldn't show up.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

web-iou-hide-copy-to-clipboard

Mobile Web

mweb-iou-hide-copy-to-clipboard

Desktop

desktop-iou-hide-copy-to-clipboard

iOS

ios-iou-hide-copy-to-clipboard

Android

android-iou-hide-copy-to-clipboard

@mananjadhav mananjadhav requested a review from a team as a code owner January 5, 2022 21:45
@MelvinBot MelvinBot requested review from parasharrajat and thienlnam and removed request for a team January 5, 2022 21:45
parasharrajat
parasharrajat approved these changes Jan 5, 2022
View reviewed changes
Copy link
Member

@parasharrajat parasharrajat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cc: @thienlnam

🎀 👀 🎀 C+ reviewed

@thienlnam thienlnam merged commit 60e6f3b into Expensify:main Jan 5, 2022
@OSBotify
Copy link
Contributor

OSBotify commented Jan 5, 2022

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Jan 5, 2022
Closed
21 tasks
@OSBotify
Copy link
Contributor

OSBotify commented Jan 6, 2022

🚀 Deployed to staging by @thienlnam in version: 1.1.25-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@botify botify mentioned this pull request Jan 10, 2022
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to production by @Jag96 in version: 1.1.26-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thienlnam thienlnam thienlnam approved these changes

@parasharrajat parasharrajat parasharrajat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mananjadhav @OSBotify @parasharrajat @thienlnam