Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: App crash on Android while resuming from background #7100

Merged
merged 2 commits into from
Jan 13, 2022
Merged

fix: App crash on Android while resuming from background #7100

merged 2 commits into from
Jan 13, 2022

Conversation

aswin-s
Copy link
Contributor

@aswin-s aswin-s commented Jan 10, 2022 •
edited
Loading

Details

This PR fixes an issue where the Android app crashes when the app is resumed from background after permission change.

Fixed Issues

$ #7008

Tests

  • Lunch app in an Android device.
  • Open a conversation with an attachment in it.
  • Tap on the attachment to view it in Attachment view
  • Tap on download icon to download the attachment
  • Kill the app and go to your phone Setting
  • Remove all permission for New Expensify
  • Disable "Remove permissions and free up space" tag.
  • Go back to New Expensify app icon and open it
  • App should restart without crash

QA Steps

  • Lunch app in an Android device.
  • Open a conversation with an attachment in it.
  • Tap on the attachment to view it in Attachment view
  • Tap on download icon to download the attachment
  • Kill the app and go to your phone Setting
  • Remove all permission for New Expensify
  • Disable "Remove permissions and free up space" tag.
  • Go back to New Expensify app icon and open it
  • App should restart without crash

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Not applicable

Mobile Web

Not applicable

Desktop

Not applicable

iOS

Not applicable

Android

Screen.Recording.2022-01-10.at.2.01.11.PM.mp4

@aswin-s aswin-s requested a review from a team as a code owner January 10, 2022 08:41
@MelvinBot MelvinBot requested review from pecanoro and rushatgabhane and removed request for a team January 10, 2022 08:41
rushatgabhane
rushatgabhane approved these changes Jan 10, 2022
View reviewed changes
Copy link
Member

@rushatgabhane rushatgabhane left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well, LGTM! 🎉
cc: @pecanoro

@rushatgabhane
Copy link
Member

Hey @aswin-s, please change tests and QA steps to a numbered list instead of check boxes 😅
Thanks!

@aswin-s
Copy link
Contributor Author

aswin-s commented Jan 10, 2022

Hey @aswin-s, please change tests and QA steps to a numbered list instead of check boxes 😅 Thanks!

Done.

@pecanoro pecanoro merged commit a4d72f7 into Expensify:main Jan 13, 2022
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Jan 14, 2022
Closed
66 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @pecanoro in version: 1.1.29-6 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@trjExpensify trjExpensify mentioned this pull request Jan 18, 2022
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.30-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rushatgabhane rushatgabhane rushatgabhane approved these changes

@pecanoro pecanoro pecanoro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aswin-s @rushatgabhane @OSBotify @pecanoro