Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block Virtual keyboard on Request Money Page #7126

Merged
merged 3 commits into from
Jan 12, 2022
Merged

Block Virtual keyboard on Request Money Page #7126

merged 3 commits into from
Jan 12, 2022

Conversation

parasharrajat
Copy link
Member

@parasharrajat parasharrajat commented Jan 11, 2022 •
edited
Loading

Details

Fixed Issues

$ #7023

Tests | QA Steps

  1. Go to staging.new.expensify.com on Mobile Web.
  2. Log in with any account
  3. Tap on Green Plus button
  4. Tap on Split/Request money.
  5. Tap on Amount field.
  6. No virtual keyboard should pop up.
  • Verify that no errors appear in the JS console

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web | Desktop

image

Mobile Web

image

iOS

Android

image

@parasharrajat parasharrajat marked this pull request as ready for review January 11, 2022 12:21
@parasharrajat parasharrajat requested a review from a team as a code owner January 11, 2022 12:21
@botify botify requested a review from chiragsalian January 11, 2022 12:21
@MelvinBot MelvinBot removed the request for review from a team January 11, 2022 12:21
chiragsalian
chiragsalian approved these changes Jan 12, 2022
View reviewed changes
Copy link
Contributor

@chiragsalian chiragsalian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@chiragsalian chiragsalian merged commit 704ba52 into Expensify:main Jan 12, 2022
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@roryabraham roryabraham mentioned this pull request Jan 12, 2022
Merged
27 tasks
@OSBotify OSBotify mentioned this pull request Jan 14, 2022
Closed
66 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @chiragsalian in version: 1.1.29-6 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@botify botify mentioned this pull request Jan 18, 2022
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.30-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chiragsalian chiragsalian chiragsalian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@parasharrajat @OSBotify @chiragsalian