Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change emoji navigation with arrow keys #7127

Merged
merged 6 commits into from
Jan 17, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 47 additions & 8 deletions src/pages/home/report/EmojiPickerMenu/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ class EmojiPickerMenu extends Component {
this.cleanupEventHandlers = this.cleanupEventHandlers.bind(this);
this.renderItem = this.renderItem.bind(this);
this.isMobileLandscape = this.isMobileLandscape.bind(this);
this.onSelectionChange = this.onSelectionChange.bind(this);

this.currentScrollOffset = 0;

Expand All @@ -92,6 +93,10 @@ class EmojiPickerMenu extends Component {
headerIndices: this.unfilteredHeaderIndices,
highlightedIndex: -1,
arePointerEventsDisabled: false,
selection: {
start: 0,
end: 0,
},
};
}

Expand All @@ -110,6 +115,16 @@ class EmojiPickerMenu extends Component {
this.cleanupEventHandlers();
}

/**
* On text input selection change
*
* @param {Event} event
*/
onSelectionChange(event) {
this.setState({selection: event.nativeEvent.selection});
}


/**
* Setup and attach keypress/mouse handlers for highlight navigation.
*/
Expand Down Expand Up @@ -169,16 +184,37 @@ class EmojiPickerMenu extends Component {
document.removeEventListener('mousemove', this.mouseMoveHandler);
}

/**
* Focuses the search Input and has the text selected
*/
focusInputWithTextSelect() {
if (!this.searchInput) {
return;
}

this.setState({selectTextOnFocus: true});
this.searchInput.focus();
}

/**
* Highlights emojis adjacent to the currently highlighted emoji depending on the arrowKey
* @param {String} arrowKey
*/
highlightAdjacentEmoji(arrowKey) {
const firstNonHeaderIndex = this.state.filteredEmojis.length === this.emojis.length ? this.numColumns : 0;

// Arrow Down enable arrow navigation when search is focused
// Arrow Down and Arrow Right enable arrow navigation when search is focused
if (this.searchInput && this.searchInput.isFocused() && this.state.filteredEmojis.length) {
if (arrowKey !== 'ArrowDown') {
if (arrowKey !== 'ArrowDown' && arrowKey !== 'ArrowRight') {
return;
}

if (arrowKey === 'ArrowRight'
&& !(
this.searchInput.value.length === this.state.selection.start
&& this.state.selection.start === this.state.selection.end
)
) {
return;
}
this.searchInput.blur();
Expand Down Expand Up @@ -220,7 +256,13 @@ class EmojiPickerMenu extends Component {
);
break;
case 'ArrowLeft':
move(-1, () => this.state.highlightedIndex - 1 < firstNonHeaderIndex);
move(-1,
() => this.state.highlightedIndex - 1 < firstNonHeaderIndex,
() => {
// Reaching start of the list, arrow left set the focus to searchInput.
this.focusInputWithTextSelect();
newIndex = -1;
});
break;
case 'ArrowRight':
move(1, () => this.state.highlightedIndex + 1 > this.state.filteredEmojis.length - 1);
Expand All @@ -230,12 +272,8 @@ class EmojiPickerMenu extends Component {
-this.numColumns,
() => this.state.highlightedIndex - this.numColumns < firstNonHeaderIndex,
() => {
if (!this.searchInput) {
return;
}

// Reaching start of the list, arrow up set the focus to searchInput.
this.searchInput.focus();
this.focusInputWithTextSelect();
newIndex = -1;
},
);
Expand Down Expand Up @@ -380,6 +418,7 @@ class EmojiPickerMenu extends Component {
ref={el => this.searchInput = el}
autoFocus
selectTextOnFocus={this.state.selectTextOnFocus}
onSelectionChange={this.onSelectionChange}
/>
</View>
)}
Expand Down