Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plaid Desktop Warning #7198

Merged
merged 8 commits into from
Jan 14, 2022
Merged

Plaid Desktop Warning #7198

merged 8 commits into from
Jan 14, 2022

Conversation

nickmurray47
Copy link
Contributor

@nickmurray47 nickmurray47 commented Jan 13, 2022 •
edited
Loading

Details

Fixed Issues

$ GH_LINK

Tests / QA steps

  1. On the desktop app, go to a workspace and click "Connect bank account".
  2. Verify that a new message appears on the Plaid Link page telling the users to open a browser tab if they are connecting to four particular banks.
  3. Click the message and verify a browser tab opens.
  4. Go to another platform, like Web, and verify the message doesn't appear.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screen Shot 2022-01-13 at 10 02 20 AM

Mobile Web

Desktop

Screen Shot 2022-01-12 at 6 17 19 PM

iOS

Android

@nickmurray47 nickmurray47 requested a review from a team as a code owner January 13, 2022 02:20
@nickmurray47 nickmurray47 self-assigned this Jan 13, 2022
@MelvinBot MelvinBot requested review from nkuoch and removed request for a team January 13, 2022 02:20
@nkuoch
Copy link
Contributor

nkuoch commented Jan 13, 2022

some failed checks

@nickmurray47
Copy link
Contributor Author

should be ready for a review again @nkuoch!

@nickmurray47
Copy link
Contributor Author

need to get Spanish translation then this should work

@nkuoch nkuoch merged commit f7f8643 into main Jan 14, 2022
@nkuoch nkuoch deleted the nmurray-plaid-desktop-route branch January 14, 2022 07:03
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Jan 14, 2022
Closed
66 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @nkuoch in version: 1.1.29-6 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.30-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkuoch nkuoch nkuoch approved these changes

Assignees

@nickmurray47 nickmurray47

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nickmurray47 @nkuoch @OSBotify