Set button size Medium for Workspace Invite and Resend Link #7224
Conversation
|
cc: @shawnborton for button design check... |
There was a problem hiding this comment.
LGTM. Leaving button design check to Shawn.
cc: @roryabraham
🎀 👀 🎀 C+ reviewed
|
Looks good! |
| @@ -139,6 +139,7 @@ class ResendValidationForm extends React.Component { | |||
| </Text> | |||
| </TouchableOpacity> | |||
| <Button | |||
| medium | |||
There was a problem hiding this comment.
Just curious - if you don't specify medium, what size is the default? I wonder if we want to make medium the default size if it's not already?
There was a problem hiding this comment.
It takes styles.button which has the height of large size with ph3 horizontal spacing.
There was a problem hiding this comment.
This ambiguity would also be removed if we had a size prop with a default value 😏
Not going to address here but in #7220 instead
| @@ -139,6 +139,7 @@ class ResendValidationForm extends React.Component { | |||
| </Text> | |||
| </TouchableOpacity> | |||
| <Button | |||
| medium | |||
There was a problem hiding this comment.
This ambiguity would also be removed if we had a size prop with a default value 😏
Not going to address here but in #7220 instead
|
🚀 Deployed to staging by @roryabraham in version: 1.1.29-7 🚀
|
|
🚀 Deployed to production by @roryabraham in version: 1.1.30-3 🚀
|
Details
Fixed Issues
$ #7037
Tests
QA Steps
For Workspace Manage Members
For Resend Link
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android