Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Onyx version #7343

Merged
merged 2 commits into from
Jan 21, 2022
Merged

Bump Onyx version #7343

merged 2 commits into from
Jan 21, 2022

Conversation

marcaaron
Copy link
Contributor

Details

IndexedDB errors are triggering storage eviction even when we are not running out of storage.

Fixed Issues

$ Expensify/react-native-onyx#115

Tests

  1. Expose Onyx as a global by putting window.Onyx = Onyx somewhere in the code
  2. In the JS Console try to set something that should not be set as data e.g.
Onyx.set('bad', {test: new FormData()});
  1. Verify that there are no messages about storage eviction and instead you see errors about IndexedDB

2022-01-20_13-10-39

QA Steps

No QA

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@marcaaron marcaaron requested a review from a team as a code owner January 20, 2022 23:11
@marcaaron marcaaron self-assigned this Jan 20, 2022
@marcaaron marcaaron changed the title [No QA] Bump Onyx version [No QA] [HOLD] Bump Onyx version Jan 20, 2022
@MelvinBot MelvinBot requested review from nickmurray47 and removed request for a team January 20, 2022 23:11
@marcaaron marcaaron changed the title [No QA] [HOLD] Bump Onyx version Bump Onyx version Jan 21, 2022
@nickmurray47 nickmurray47 merged commit 60953b2 into main Jan 21, 2022
@nickmurray47 nickmurray47 deleted the marcaaron-bumpOnyx branch January 21, 2022 22:05
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @nickmurray47 in version: 1.1.32-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Feb 1, 2022

🚀 Deployed to production by @roryabraham in version: 1.1.33-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants