Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix : Unable to type next paragraph in message #7355

Merged
merged 10 commits into from
Jan 24, 2022

Conversation

ahmdshrif
Copy link
Contributor

@ahmdshrif ahmdshrif commented Jan 21, 2022

Details

Fixed Issues

$ #6767

Tests/QA Steps

1- Go to app
2- Open any chat
3- Type 1 line & hit return to add a paragraph in same message

  • verify that enter make a new line in the mobile web and touchable device.
  • very that enter send massage for the desktop and desktop web.
  • Verify that no errors appear in the JS console

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screen.Recording.2022-01-21.at.9.28.49.AM.mov

Mobile Web

Screen_Recording_20220121-093128_Samsung.Internet.mp4

Desktop

Screen.Recording.2022-01-21.at.9.37.32.AM.mov

iOS

Screen.Recording.2022-01-21.at.11.23.17.AM.mov

Android

Screen.Recording.2022-01-21.at.9.56.02.AM.mov

@ahmdshrif ahmdshrif marked this pull request as ready for review January 21, 2022 09:32
@ahmdshrif ahmdshrif requested a review from a team as a code owner January 21, 2022 09:32
@MelvinBot MelvinBot removed the request for review from a team January 21, 2022 09:32
src/pages/home/report/ReportActionCompose.js Outdated Show resolved Hide resolved
src/pages/home/report/ReportActionCompose.js Outdated Show resolved Hide resolved
src/pages/home/report/ReportActionCompose.js Outdated Show resolved Hide resolved
src/pages/home/report/ReportActionCompose.js Outdated Show resolved Hide resolved
ahmdshrif and others added 4 commits January 21, 2022 14:45
Co-authored-by: Rajat Parashar <parasharrajat@users.noreply.github.com>
Co-authored-by: Rajat Parashar <parasharrajat@users.noreply.github.com>
Co-authored-by: Rajat Parashar <parasharrajat@users.noreply.github.com>
Co-authored-by: Rajat Parashar <parasharrajat@users.noreply.github.com>
Co-authored-by: Rajat Parashar <parasharrajat@users.noreply.github.com>
parasharrajat
parasharrajat previously approved these changes Jan 21, 2022
Copy link
Member

@parasharrajat parasharrajat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

cc: @roryabraham
🎀 👀 🎀 C+ reviewed

parasharrajat
parasharrajat previously approved these changes Jan 22, 2022
src/pages/home/report/ReportActionCompose.js Outdated Show resolved Hide resolved
src/pages/home/report/ReportActionCompose.js Show resolved Hide resolved
src/libs/virtualKeyboard.js Outdated Show resolved Hide resolved
Co-authored-by: Rory Abraham <47436092+roryabraham@users.noreply.github.com>
Copy link
Contributor

@roryabraham roryabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and tests well

@roryabraham
Copy link
Contributor

@ahmdshrif Thanks for making those few updates I requested 👍

@roryabraham roryabraham merged commit 3e61a1d into Expensify:main Jan 24, 2022
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@ahmdshrif
Copy link
Contributor Author

thanks @roryabraham

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @roryabraham in version: 1.1.32-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Feb 1, 2022

🚀 Deployed to production by @roryabraham in version: 1.1.33-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants