Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CP Stg] Resolve getImageSize promise with an object instead of multiple values #7414

Merged
merged 1 commit into from
Jan 26, 2022
Merged

[CP Stg] Resolve getImageSize promise with an object instead of multiple values #7414

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/ImageWithSizeCalculation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ class ImageWithSizeCalculation extends PureComponent {
getImageSize(url) {
return new Promise((resolve, reject) => {
Image.getSize(url, (width, height) => {
resolve(width, height);
resolve({width, height});
}, (error) => {
reject(error);
});
Expand All @@ -70,7 +70,7 @@ class ImageWithSizeCalculation extends PureComponent {

this.getImageSizePromise = makeCancellablePromise(this.getImageSize(this.props.url));
this.getImageSizePromise.promise
.then((width, height) => {
.then(({width, height}) => {
if (!width || !height) {
// Image didn't load properly
return;
Expand Down