Fix broken duplicate name error in User Created Policy Rooms #7446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomatoToaster
changed the title
TomatoToaster
changed the title
|
Rerunning ios I don't think the failing test is related. |
|
Friendly bump on this @pecanoro when you get the time! |
|
I really thought I had reviewed this lol Let me take a look now |
pecanoro
approved these changes
Feb 3, 2022
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
22 tasks
|
🚀 Deployed to production by @roryabraham in version: 1.1.36-0 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pecanoro, please review when you get the chance.
Details
Fixes the bug where we don't show an error if you try to create a policy room with the same name as one just created. What was happening was that we weren't checking for duplicates after a policy was selected - we were only doing it when the room name's text changed. This will fix that and show the error in the WorkspaceNew component.
Fixed Issues
$ #7260
Tests/WebQA
Go to https://staging.new.expensify.com/
Create room e.g. "fish" (Use Green + on the bottom left. You need to have a workspace also)
Create second room with same name "fish". First type the name fish in and THEN select a workspace.
An error should show up after you select the workspace and it should prevent you from clicking "Create Room"
Tested On