Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NO QA] Fix shouldUseSecure logged data #7449

Merged
merged 1 commit into from
Jan 28, 2022
Merged

[NO QA] Fix shouldUseSecure logged data #7449

merged 1 commit into from
Jan 28, 2022

Conversation

Beamanator
Copy link
Contributor

@Beamanator Beamanator commented Jan 28, 2022 •
edited
Loading

Details

Just noticed the shouldUseSecure log was logging type here

@marcaaron requesting your review since you wrote this originally

Fixed Issues

None

Tests

N/A

QA Steps

N/A

@Beamanator Beamanator requested a review from marcaaron January 28, 2022 11:40
@Beamanator Beamanator self-assigned this Jan 28, 2022
@Beamanator Beamanator requested a review from a team as a code owner January 28, 2022 11:40
@MelvinBot MelvinBot requested review from chiragsalian and removed request for a team January 28, 2022 11:40
@Beamanator Beamanator removed the request for review from chiragsalian January 28, 2022 11:40
@marcaaron marcaaron merged commit 77b7fa2 into main Jan 28, 2022
@marcaaron marcaaron deleted the beaman-fixSecureLog branch January 28, 2022 16:02
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Feb 1, 2022
Closed
46 tasks
@OSBotify
Copy link
Contributor

OSBotify commented Feb 1, 2022

🚀 Deployed to staging by @marcaaron in version: 1.1.33-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Feb 2, 2022

🚀 Deployed to production by @sketchydroide in version: 1.1.34-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcaaron marcaaron marcaaron approved these changes

Assignees

@Beamanator Beamanator

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Beamanator @OSBotify @marcaaron