Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update HOW_TO_CREATE_A_PLAN.md #7488

Merged
merged 1 commit into from
Jan 31, 2022
Merged

Update HOW_TO_CREATE_A_PLAN.md #7488

merged 1 commit into from
Jan 31, 2022

Conversation

mallenexpensify
Copy link
Contributor

Updated out-of-the-box to outside-of-the-box

Details

Updated out-of-the-box to outside-of-the-box, that's it

Fixed Issues

$ GH_LINK

Tests

Make sure outside-of-the-box shows and not out-of-the-box

  • Verify that no errors appear in the JS console

QA Steps

  • Verify that no errors appear in the JS console

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@mallenexpensify
Update HOW_TO_CREATE_A_PLAN.md
2672cf9 
Updated out-of-the-box to outside-of-the-box
@mallenexpensify mallenexpensify requested a review from a team as a code owner January 31, 2022 20:35
@MelvinBot MelvinBot requested review from timszot and removed request for a team January 31, 2022 20:35
@mountiny mountiny self-requested a review January 31, 2022 20:36
mountiny
mountiny approved these changes Jan 31, 2022
View reviewed changes
Copy link
Contributor

@mountiny mountiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coming from DM, quick change, merging.

@mountiny mountiny merged commit 2c14f01 into main Jan 31, 2022
@mountiny mountiny deleted the mallenexpensify-patch-1 branch January 31, 2022 22:50
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Feb 1, 2022
Closed
46 tasks
@OSBotify
Copy link
Contributor

OSBotify commented Feb 1, 2022

🚀 Deployed to staging by @mountiny in version: 1.1.33-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Feb 2, 2022

🚀 Deployed to production by @sketchydroide in version: 1.1.34-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mountiny mountiny mountiny approved these changes

@timszot timszot Awaiting requested review from timszot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mallenexpensify @OSBotify @mountiny