[HOLD][No QA] Add automated tests for Report actions/ Pusher #771
Conversation
To clarify, do mean something like "change how Ion works to see if the tests are still passing" or "write test cases that should fail and verifying they fail"? I guess I'm not sure what you want me to do exactly. But I'm up for it if you think it's necessary. |
|
Adding @AndrewGable for another set of eyes since he has the most experience with tests. |
marcaaron
changed the title
| @@ -18,6 +18,7 @@ | |||
| "android-build": "fastlane android build", | |||
| "test": "jest", | |||
| "lint": "eslint .", | |||
| "lint-tests": "eslint tests/**", | |||
There was a problem hiding this comment.
Are we separating out linting tests and the source? Ideally they are the same, right?
src/libs/API.js
Outdated
| @@ -70,6 +70,11 @@ function isAuthTokenRequired(command) { | |||
| * @returns {Promise} | |||
| */ | |||
| function queueRequest(command, data) { | |||
| // Mock all requests for now | |||
| if (CONFIG.IS_JEST_RUNNING) { | |||
There was a problem hiding this comment.
While this works, I thought the preferred method was to mock API.js and make queueRequest just return an empty function (or something similar). Is there a reason we can't go that route?
There was a problem hiding this comment.
Yea I'll look into this.
| require('pusher-js-mock').PusherMock | ||
| )); | ||
|
|
||
| jest.mock('../../node_modules/@react-native-community/netinfo', () => ( |
There was a problem hiding this comment.
I'm curious if we'd prefer to put all these mocks in a different file and then import them? It might DRY up the tests a bit.
There was a problem hiding this comment.
I'll try to get this working.
|
Gonna close this until I have time to investigate how to fix this. Also I think we should have a broader conversation about testing and test conventions. Specifically, agreeing to the use of async/await to make linear testing of asynchronous JS easier would be nice. That was my main blocker when attempting to write these tests. |
cc @AndrewGable
This adds a mocked test for one of our most critical flows
Optimistic comment > Create comment in server (this is mocked) > Pusher handles comment > Expected response verified in
IonFixed Issues
Fixes https://github.com/Expensify/Expensify/issues/145497
Tests
Automated tests were added.
Screenshots
❌