Remove default payment method for paypal

[mdneyazahmad]

Details

Fixed Issues

$ #7518

Tests

1. Goto settings -> Payments -> Paypal
2. Click on a already added paypal method
3. Verify that there is no set default payment button for it

• Verify that no errors appear in the JS console

QA Steps

1. Goto settings -> Payments -> Paypal
2. Click on a already added paypal method
3. Verify that there is no set default payment button for it
4. Verify that other payment method can be selected as default method

• Verify that no errors appear in the JS console

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

[rushatgabhane]

@puneetlath LGTM! 🎉️ and tests well on all platforms.

[puneetlath]

@mdneyazahmad let's add to the QA steps to make sure that other payment methods can still be removed and set as default.

[mdneyazahmad]

@puneetlath updated the steps

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by @puneetlath in version: 1.1.39-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by @timszot in version: 1.1.39-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[SumitDiyora]

Issue 1 -

Title- [Medium]: Chrome+Jaws: Screen reader: Role is not defined for Paypal A/c.
Actual - When focus lands on the Paypal A/c, screen reader is reading "Paypal.me testetstes(A/c name)", not read the role for the A/c.
Expected - Role should be define as a 'button' for the paypal a/c and screen reader should read like "Paypal.me testetstes".
WCAG failure - 4.1.2
Reproducible in staging?: - Yes
Version Number: - v1.1.39-3
Platforms - Web, Desktop, Mobile-web, iOS, Android

Role.not.defined.for.Paypal.me.account.mp4

Issue 2-

Title- [Medium]: Chrome+Jaws: Keyboard Navigation: Order is not sequential on 'Delete dialogue'
Actual - After opening the dialogue first focus lands on the Cancel control then it's moved to delete control.
Expected - Focus should first land on the 'Delete' control then should land on the 'Cancel'.
WCAG failure - 2.4.3
Reproducible in staging?: - Yes
Version Number: - v1.1.39-3
Platforms - Web, Desktop

focus.moves.inappropraitely.mp4

Issue 3 -

Title- [Medium]: Chrome +Jaws : Screen reader : Role is not defined for 'Delete' control.
Actual - When focus lands on the Delete control, screen reader is reading "Delete", not read the role.
Expected - Role should be define as 'button' and screen reader should read like "Delete button".
WCAG failure - 4.1.2
Reproducible in staging?: - Yes
Version Number: - v1.1.39-3
Platforms - Web, Desktop, Mobile-web, iOS, Android

Role.not.defined.for.delete.and.cancel.control.mp4

Issue 4 -

Title- [Medium]: Chrome +Jaws : Screen reader : Screen reader is not reading the Dialogue information.
Actual - After select the delete control, screen reader is reading "Cancel", not read the 'Are you sure...".
Expected - Screen reader should read like "Are you sure that you want to delete this account?, cancel button".
WCAG failure - 1.3.1
Reproducible in staging?: - Yes
Version Number: - v1.1.39-3
Platforms - Web

Screen.reader.does.not.announce.dailouge.information.along.with.the.controls.mp4