fix: crash when value is `undefined` #7782

parasharrajat · 2022-02-16T18:20:51Z

Details

ComponentDidUpdate was allowing the undefined value to be pass down to native TextInput value which was causing an issue. So I added a check if that value prop is undefined (~not provided), skip the update.

Fixed Issues

$ #7769
$ #7774
$ #7775
$ #7869

Tests

Open the Payments page and tried to set a payment method as default and the password popup should come up and no errors.

Verify that no errors appear in the JS console

QA Steps

Go to the payments page.
Click any existing payment method to set it to default.
Click set default and no error should pop up.

Verify that no errors appear in the JS console

Tested On

Screenshots

Web | Desktop

Mobile Web

iOS

Android

parasharrajat · 2022-02-16T18:21:13Z

Updating screens shortly.....testing more issues.

parasharrajat · 2022-02-16T22:46:17Z

I will update the IOS screen tomorrow. But I am pretty sure it is working.

parasharrajat · 2022-02-17T18:28:12Z

Could you please test it on IOS? I am getting a build error on IOS. I don't know what changed.

parasharrajat · 2022-02-17T20:23:37Z

Ok, App is built now but I am facing App freezing issue When I click setDefultmethod on the Payment Option Menu. On the other hand, I don't know how to test the complete VBA flow. I am stuck on the captcha step.

Can someone please test IOS? Otherwise, this is ready.

cc: @Beamanator

Julesssss · 2022-02-18T14:46:26Z

Sorry, @parasharrajat I tried to verify this for you but I've had a lot of problems trying to verify this, none of which are related to the PR 😩

First I created some bank accounts with the generator script. Then I created an Expensify wallet. Next, I upgraded it to Gold. But I'm still not able to link a bank account to a wallet... All three of my accounts show that I'm using an invalid bank account when setting them as the default, but the error doesn't explain why.

I modified the Auth code in order to give me the exact reason why, but now I'm getting 666 after updating and need to reprovision as updateRepos w/ build didn't work either. My last attempt will be to restart my machine, which I'll do after sending this.

parasharrajat · 2022-02-18T16:10:30Z

I was able to fix the App freezing issue and Test it and it is not crashing the app. I will attach the screen shotly.

Beamanator · 2022-02-21T08:43:34Z

Sorry guys I'm pretty heads down in a design doc I didn't have time to test last weekend and may not have time today either :'( If @Julesssss is having many problems we can ping another engineer to help test

sketchydroide · 2022-02-21T13:30:40Z

I'll try testing this today

nkuoch · 2022-02-22T17:13:47Z

Just FYI, I've been using this fix in the PRs I am working on because I had the bug, and it works well. (#7804 and #7813) ... and would love to see it merged ASAP so I can merge it in my PRs :)

parasharrajat · 2022-02-22T17:18:19Z

Thanks, @nkuoch for your input.

timszot · 2022-02-22T20:05:47Z

Alright, so this looks to solve our 3 deploy blocker issues. @nkuoch you said you've been testing this in relation to your own changes, which is great. Do you have time to review/merge this PR since the two assigned haven't had a chance to get to it so we can unblock the deploy?

github-actions · 2022-02-22T20:11:45Z

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

fix: crash when value is `undefined` (cherry picked from commit 8582db0)

OSBotify · 2022-02-22T22:33:05Z

🚀 Cherry-picked to staging by @nkuoch in version: 1.1.39-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

stitesExpensify · 2022-02-23T19:20:09Z

src/components/TextInput/BaseTextInput.js

@@ -59,7 +59,8 @@ class BaseTextInput extends Component {

    componentDidUpdate() {
        // Activate or deactivate the label when value is changed programmatically from outside
-        if (this.value === this.props.value) {
+        // Only update when value prop is provided
+        if (this.props.value === undefined || this.value === this.props.value) {


NAB _.isUndefined(this.props.value)

Yeah, I will do that in #6584 during refactoring.

OSBotify · 2022-02-23T21:20:53Z

🚀 Deployed to production by @timszot in version: 1.1.39-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix: crash when value is undefined

26211c7

parasharrajat requested a review from a team as a code owner February 16, 2022 18:20

MelvinBot requested review from Beamanator and removed request for a team February 16, 2022 18:20

This was referenced Feb 16, 2022

Web - VBA - Unable to enter date in company info and personal info page using date picker or manually #7774

Closed

Web - Page with error message(crashed) when selecting Settings button from room details #7786

Closed

nkuoch mentioned this pull request Feb 18, 2022

P2P KYC - Ask user to provide full SSN when LexisNexis cannot #7804

Merged

5 tasks

Julesssss self-requested a review February 18, 2022 12:30

Julesssss mentioned this pull request Feb 18, 2022

Deploy Checklist: New Expensify 2022-02-15 #7759

Closed

85 tasks

timszot added the CP Staging label Feb 22, 2022

nkuoch approved these changes Feb 22, 2022

View reviewed changes

nkuoch merged commit 8582db0 into Expensify:main Feb 22, 2022

OSBotify pushed a commit that referenced this pull request Feb 22, 2022

Merge pull request #7782 from parasharrajat/fix-textinput-crash

099a476

fix: crash when value is `undefined` (cherry picked from commit 8582db0)

OSBotify mentioned this pull request Feb 22, 2022

🍒 Cherry pick PR #7782 to staging 🍒 #7867

Merged

This was referenced Feb 22, 2022

Payments - Error message appears when making a bank account as a default payment #7868

Closed

IOS - App is freezing after tap on "Make default payment method" #7869

Closed

parasharrajat mentioned this pull request Feb 23, 2022

Payment - Setting a default payment method throws an JS error #7769

Closed

stitesExpensify reviewed Feb 23, 2022

View reviewed changes

OSBotify mentioned this pull request Feb 24, 2022

Deploy Checklist: New Expensify 2022-02-23 #7883

Closed

69 tasks

michaelhaxhiu mentioned this pull request Mar 25, 2022

[HOLD for payment 2022-04-01] Simplify/consolidate our various Text Input components #6584

Closed

OSBotify mentioned this pull request Aug 16, 2022

Deploy Checklist: New Expensify 2022-08-04 #10253

Closed

parasharrajat deleted the fix-textinput-crash branch November 20, 2023 13:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: crash when value is `undefined` #7782

fix: crash when value is `undefined` #7782

parasharrajat commented Feb 16, 2022 •

edited by TomatoToaster

Loading

parasharrajat commented Feb 16, 2022

parasharrajat commented Feb 16, 2022

parasharrajat commented Feb 17, 2022

parasharrajat commented Feb 17, 2022

Julesssss commented Feb 18, 2022

parasharrajat commented Feb 18, 2022 •

edited

Loading

Beamanator commented Feb 21, 2022

sketchydroide commented Feb 21, 2022

nkuoch commented Feb 22, 2022

parasharrajat commented Feb 22, 2022

timszot commented Feb 22, 2022

github-actions bot commented Feb 22, 2022

OSBotify commented Feb 22, 2022

stitesExpensify Feb 23, 2022

parasharrajat Feb 23, 2022

OSBotify commented Feb 23, 2022

fix: crash when value is undefined #7782

fix: crash when value is undefined #7782

Conversation

parasharrajat commented Feb 16, 2022 • edited by TomatoToaster Loading

Details

Fixed Issues

Tests

QA Steps

Tested On

Screenshots

Web | Desktop

Mobile Web

iOS

Android

parasharrajat commented Feb 16, 2022

parasharrajat commented Feb 16, 2022

parasharrajat commented Feb 17, 2022

parasharrajat commented Feb 17, 2022

Julesssss commented Feb 18, 2022

parasharrajat commented Feb 18, 2022 • edited Loading

Beamanator commented Feb 21, 2022

sketchydroide commented Feb 21, 2022

nkuoch commented Feb 22, 2022

parasharrajat commented Feb 22, 2022

timszot commented Feb 22, 2022

github-actions bot commented Feb 22, 2022

OSBotify commented Feb 22, 2022

stitesExpensify Feb 23, 2022

Choose a reason for hiding this comment

parasharrajat Feb 23, 2022

Choose a reason for hiding this comment

OSBotify commented Feb 23, 2022

fix: crash when value is `undefined` #7782

fix: crash when value is `undefined` #7782

parasharrajat commented Feb 16, 2022 •

edited by TomatoToaster

Loading

parasharrajat commented Feb 18, 2022 •

edited

Loading