Fix Android text selection context menu (copy, paste) #7815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kidroca
force-pushed
the
kidroca/fix/android-text-input-context-menu
branch
from
81cde26 to
1797f30
Compare
|
Close old PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Related to slack thread: https://expensify.slack.com/archives/C01GTK53T8Q/p1645201764524639?thread_ts=1645191589.301989&cid=C01GTK53T8Q
Using controlled
selectionis not allowing the user to control the selection freelySwitching to uncontrolled
selectionaddresses the issue and improves performance a bitFixed Issues
$ #6876
Tests
QA Steps
Tested On
Screenshots
Web
Screen.Recording.2022-03-24.at.20.37.03.mov
Mobile Web
Screen.Recording.2022-03-24.at.20.39.43.mov
Desktop
iOS
Screen.Recording.2022-03-24.at.20.24.19.mov
Android
Android.Emulator.-.Pixel_2_API_29_5554.2022-02-18.18-27-36.mp4