Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT MERGE]Fix/wkspace settings lock after delete #8023

Closed
wants to merge 12 commits into from
Closed

[DO NOT MERGE]Fix/wkspace settings lock after delete #8023

wants to merge 12 commits into from

Conversation

mananjadhav
Copy link
Collaborator

@mananjadhav mananjadhav commented Mar 7, 2022 •
edited
Loading

Details

Fixed Issues

$ #7432

Tests

  • Verify that no errors appear in the JS console

PR Review Checklist

Contributor (PR Author) Checklist

  • I verified the PR has a small number of commits behind main
  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I clearly indicated the environment tests should be run in (Staging vs Production)
  • I wrote testing steps that cover success & fail scenarios (if applicable)
  • I included screenshots or videos for tests on all platforms
  • I ran the tests & veryfy they passed on:
    • iOS / native
    • Android / native
    • iOS / Safari
    • Android / Chrome
    • MacOS / Chrome
    • MacOS / Desktop
  • I verified there are no console errors related to changes in this PR
  • I followed proper code patterns (see Reviewing the code)
    • I added comments when the code was not self explanatory
    • I put all copy / text shown in the product in all src/languages/* files (if applicable)
    • I followed proper naming convention for platform-specific files (if applicable)
    • I followed style guidelines (in Styling.md) for all style edits I made
    • I followed the JSDocs style guidelines (in STYLE.md)
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I corroborated the UI performance was not affected (the performance is the same than main branch)
  • If I created a new component I verified that a similar component doesn't exist in the codebase

PR Reviewer Checklist

  • I verified the PR has a small number of commits behind main
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the testing environment is mentioned in the test steps
  • I verified testing steps cover success & fail scenarios (if applicable)
  • I checked that screenshots or videos are included for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • iOS / native
    • Android / native
    • iOS / Safari
    • Android / Chrome
    • MacOS / Chrome
    • MacOS / Desktop
  • I verified there are no console errors related to changes in this PR
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified comments were added when the code was not self explanatory
    • I verified any copy / text shown in the product was added in all src/languages/* files (if applicable)
    • I verified proper naming convention for platform-specific files was followed (if applicable)
    • I verified style guidelines were followed
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components are not impacted by changes in this PR (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified the UI performance was not affected (the performance is the same than main branch)
  • If a new component is created I verified that a similar component doesn't exist in the codebase

QA Steps

  • Verify that no errors appear in the JS console

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@pecanoro pecanoro mentioned this pull request May 16, 2022
Closed
@mananjadhav mananjadhav marked this pull request as ready for review May 19, 2022 04:50
@mananjadhav mananjadhav requested a review from a team as a code owner May 19, 2022 04:50
@melvin-bot melvin-bot bot requested review from pecanoro and removed request for a team and pecanoro May 19, 2022 04:50
@mananjadhav mananjadhav changed the title Fix/wkspace settings lock after delete [DO NOT MERGE]Fix/wkspace settings lock after delete May 19, 2022
@pecanoro
Copy link
Contributor

I will test this tomorrow, sorry for the delay, I forgot about it!

@pecanoro
Copy link
Contributor

pecanoro commented Jun 6, 2022

@mananjadhav Sorry for the delay! It seems to be working fine even without forcing the code, but can you solve the conflicts so I can do a final test? Also, can you post the videos and screenshots? Even if you have to be hacky and you have to "manually changing the flags".

@mananjadhav
Copy link
Collaborator Author

Okay thanks a lot @pecanoro. I'll probably manually change the data in Onyx and then add the screenshots? I'll be offline tomorrow and I'll be able to submit this by Wednesday only.

@mananjadhav
Copy link
Collaborator Author

Issues with the commit history. Closing this one and tracking here #9490

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pecanoro pecanoro Awaiting requested review from pecanoro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mananjadhav @pecanoro