-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make payment method preview non interactive #8025
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
cc: @tgolen
PR Reviewer Checklist
- I verified the Author pulled
main
before submitting the PR - I verified the correct issue is linked in the
### Fixed Issues
section above - I verified testing steps are clear and they cover the changes made in this PR
- I verified the testing environment is mentioned in the test steps
- I verified testing steps cover success & fail scenarios (if applicable)
- I verified tests pass on all platforms & I tested again on all platforms
- I checked that screenshots or videos are included for tests on all platforms
- I verified there are no console errors related to changes in this PR
- I verified proper code patterns were followed (see Reviewing the code)
- I verified comments were added when the code was not self explanatory
- I verified any copy / text shown in the product was added in all
src/languages/*
files (if applicable) - I verified proper naming convention for platform-specific files was followed (if applicable)
- I verified style guidelines were followed
- I verified that this PR follows the guidelines as stated in the Review Guidelines
🎀 👀 🎀 C+ reviewed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but looks like there are still checklist items not checked off, so I cannot merge yet.
I have checked all the applicable checkboxes now |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Tested the PR on staging and it LGTM. The issue about deleting paypal is handled separately so i'm checking this issue off the checklist. |
🚀 Deployed to production by @chiragsalian in version: 1.1.42-6 🚀
|
Details
Make payment method preview non interactive
Fixed Issues
$ #7972
Tests
PR Review Checklist
Contributor (PR Author) Checklist
main
### Fixed Issues
section abovesrc/languages/*
files (if applicable)Styling.md
) for all style edits I madeSTYLE.md
)Avatar
, I verified the components usingAvatar
are working as expected)main
branch)QA Steps
Screenshots
Web
web.mov
Mobile Web
Desktop
iOS
ios.mov
Android