Styling on storybook sidebar in mWeb is broken

[mollfpr]

Details

1. Add a CSS to change sidebar background
2. Add ../assets/css to serve staticly
3. Call fonts.css from ../assets/css to make font work

Fixed Issues

$ #7842

Tests

1. Run storybook and verify the font base is GTAmericaExp-Regular
2. Open storybook from mobile web and click sidebar navigation, verify the background is changed and the texts are visible

• Verify that no errors appear in the JS console

PR Review Checklist

Contributor (PR Author) Checklist

• I verified the PR has a small number of commits behind main
• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I clearly indicated the environment tests should be run in (Staging vs Production)
• I wrote testing steps that cover success & fail scenarios (if applicable)
• I included screenshots or videos for tests on all platforms
• I ran the tests & veryfy they passed on:
  • iOS / native
  • Android / native
  • iOS / Safari
  • Android / Chrome
  • MacOS / Chrome
  • MacOS / Desktop
• I verified there are no console errors related to changes in this PR
• I followed proper code patterns (see Reviewing the code)
  • I added comments when the code was not self explanatory
  • I put all copy / text shown in the product in all src/languages/* files (if applicable)
  • I followed proper naming convention for platform-specific files (if applicable)
  • I followed style guidelines (in Styling.md) for all style edits I made
  • I followed the JSDocs style guidelines (in STYLE.md)
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I corroborated the UI performance was not affected (the performance is the same than main branch)
• If I created a new component I verified that a similar component doesn't exist in the codebase

PR Reviewer Checklist

• I verified the PR has a small number of commits behind main
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the testing environment is mentioned in the test steps
• I verified testing steps cover success & fail scenarios (if applicable)
• I checked that screenshots or videos are included for tests on all platforms
• I verified tests pass on all platforms & I tested again on:
  • iOS / native
  • Android / native
  • iOS / Safari
  • Android / Chrome
  • MacOS / Chrome
  • MacOS / Desktop
• I verified there are no console errors related to changes in this PR
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified comments were added when the code was not self explanatory
  • I verified any copy / text shown in the product was added in all src/languages/* files (if applicable)
  • I verified proper naming convention for platform-specific files was followed (if applicable)
  • I verified style guidelines were followed
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components are not impacted by changes in this PR (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified the UI performance was not affected (the performance is the same than main branch)
• If a new component is created I verified that a similar component doesn't exist in the codebase

QA Steps

1. Go to https://staging.new.expensify.com/docs/index.html and verify the font base is GTAmericaExp-Regular (and not something obviously different like Times New Roman)
2. Go to https://staging.new.expensify.com/docs/index.html from mobile web and click sidebar navigation, verify the background is changed and the texts are visible

• Verify that no errors appear in the JS console

Screenshots

Web

Safari

Chrome

Mobile Web

Desktop

iOS

Android

[roryabraham]

@mollfpr I updated your QA steps a bit. Since QA happens in our staging environment, it doesn't really make sense to "Run storybook". Storybook is hosted at /docs/index.html, so I added a link to clarify that.

[mollfpr]

@roryabraham thank you for clearing things up!

[roryabraham]

Looks good and tests well!

[roryabraham]

Whoops, I can't merge this because we require all git commits to be signed. This is pretty easy to do and there's lots of documentation out there for how to set up commit signing. Once you have commit signing working, you can retroactively sign all these commits by:

1. git rebase -i HEAD~2
2. For each commit, enter this in vim: :%substitute/^pick/reword/ then save and quit.
3. Force-push your changes in this PR.

[roryabraham]

Here is one set of instructions you could follow: https://webdevstudios.com/2020/05/26/retroactively-sign-git-commits/

[mollfpr]

@roryabraham Done!

[mollfpr]

@roryabraham Sorry I rebase the commit again. Turn out my gitconfig that signingkey not setup properly.

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by @roryabraham in version: 1.1.42-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[mollfpr]

Updates link to test

[OSBotify]

🚀 Deployed to production by @chiragsalian in version: 1.1.42-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅