Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix console errors from auto-fill #8163

Merged
merged 1 commit into from
Mar 15, 2022
Merged

Fix console errors from auto-fill #8163

merged 1 commit into from
Mar 15, 2022

Conversation

roryabraham
Copy link
Contributor

@roryabraham roryabraham commented Mar 15, 2022 •
edited
Loading

cc @rushatgabhane

Details

There were some console errors on staging related to #8059 that happen when using Google Chrome's autofill functionality. This should patch those errors.

Fixed Issues

$ #8059

Tests

  1. Verify that keyboard shortcuts continue to work as expected. (CMD+K, CMD+I, CMD+SHIFT+K, ESC, etc...)
  2. Use Google Chrome's autofill on a form in NewDot. Make sure that no console error appears.
  • Verify that no errors appear in the JS console

PR Review Checklist

Contributor (PR Author) Checklist

  • I verified the PR has a small number of commits behind main
  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I clearly indicated the environment tests should be run in (Staging vs Production)
  • I wrote testing steps that cover success & fail scenarios (if applicable)
  • I included screenshots or videos for tests on all platforms
  • I ran the tests & verified they passed on:
    • iOS / native
    • Android / native
    • iOS / Safari
    • Android / Chrome
    • MacOS / Chrome
    • MacOS / Desktop
  • I verified there are no console errors related to changes in this PR
  • I followed proper code patterns (see Reviewing the code)
    • I added comments when the code was not self explanatory
    • I put all copy / text shown in the product in all src/languages/* files (if applicable)
    • I followed proper naming convention for platform-specific files (if applicable)
    • I followed style guidelines (in Styling.md) for all style edits I made
    • I followed the JSDocs style guidelines (in STYLE.md)
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I corroborated the UI performance was not affected (the performance is the same than main branch)
  • If I created a new component I verified that a similar component doesn't exist in the codebase

PR Reviewer Checklist

  • I verified the PR has a small number of commits behind main
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the testing environment is mentioned in the test steps
  • I verified testing steps cover success & fail scenarios (if applicable)
  • I checked that screenshots or videos are included for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • iOS / native
    • Android / native
    • iOS / Safari
    • Android / Chrome
    • MacOS / Chrome
    • MacOS / Desktop
  • I verified there are no console errors related to changes in this PR
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified comments were added when the code was not self explanatory
    • I verified any copy / text shown in the product was added in all src/languages/* files (if applicable)
    • I verified proper naming convention for platform-specific files was followed (if applicable)
    • I verified style guidelines were followed
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components are not impacted by changes in this PR (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified the UI performance was not affected (the performance is the same than main branch)
  • If a new component is created I verified that a similar component doesn't exist in the codebase

QA Steps

  1. Open the JS console.
  2. Use Google Chrome's autofill functionality on an input in NewDot.
  3. Verify that no console errors appear.
  • Verify that no errors appear in the JS console

@roryabraham roryabraham requested a review from a team as a code owner March 15, 2022 18:18
@roryabraham roryabraham self-assigned this Mar 15, 2022
@MelvinBot MelvinBot requested review from yuwenmemon and removed request for a team March 15, 2022 18:19
@roryabraham
Copy link
Contributor Author

I didn't attach screenshots because I think I disabled Chrome's autofill in preference of 1Password. @rushatgabhane can you please help out with the testing on this? Credit should go to you anyways since this PR was your suggestion.

rushatgabhane
rushatgabhane approved these changes Mar 15, 2022
View reviewed changes
Copy link
Member

@rushatgabhane rushatgabhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

Screen.Recording.2022-03-15.at.9.51.58.PM.mov

@yuwenmemon yuwenmemon merged commit a94070d into main Mar 15, 2022
@yuwenmemon yuwenmemon deleted the Rory-PatchKeyboardShortcuts branch March 15, 2022 19:08
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Mar 15, 2022
Closed
52 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @yuwenmemon in version: 1.1.43-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.43-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@SumitDiyora SumitDiyora mentioned this pull request Apr 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rushatgabhane rushatgabhane rushatgabhane approved these changes

@yuwenmemon yuwenmemon yuwenmemon approved these changes

Assignees

@roryabraham roryabraham

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@roryabraham @OSBotify @yuwenmemon @rushatgabhane