Final Network Cleanup

[marcaaron]

Details

Final Network cleanup PR. This one has less changes than the other two.

Summary of Changes

• Moved "pre-request" and "error" handlers out of API.js and killed their related events
• Centralized response handling logic in processRequest() instead of duplicated logic in 2 places h/t to @marcochavezf for this idea
• Remove unused setSessionLoadingAndError() method as it does not appear to be needed and was setting an untranslated string.

Fixed Issues

No Issue - Related to Offline Doc

Tests

Existing automated tests should cover the changes made (we are just moving some logic around and reorganizing things).

QA

Make sure that offline report comments feature is still working as intended.

[marcaaron]

cc @roryabraham @marcochavezf since you all reviewed the first 2 clean up PRs

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by @roryabraham in version: 1.1.47-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[roryabraham]

@mvtglobally Can you please confirm that these QA steps are covered by existing regression tests? More detailed test steps should look something like this:

1. Open a chat report.
2. Put your device on airplane mode and disconnect from wifi.
3. Send a few messages in the chat.
4. Close the app.
5. Reopen the app, verify you can still see the chats you sent while offline.
6. Take your device off airplane mode and/or reconnect to wifi.
7. Verify that you can still see the chats you sent while offline.
8. Sign out and sign back in.
9. Verify that you can still see the chats you sent while offline.

[OSBotify]

🚀 Deployed to production by @roryabraham in version: 1.1.49-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅