-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix linkedWorkspace find policy null #8427
Conversation
Co-authored-by: Rajat Parashar <parasharrajat@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
cc: @marcochavezf
Contributor (PR Author) Checklist
- I linked the correct issue in the
### Fixed Issues
section above - I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the
Tests
section - I added steps for Staging and/or Production testing in the
QA steps
section - I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I added steps for local testing in the
- I included screenshots or videos for tests on all platforms
- I ran the tests on all platforms & verified they passed on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
- I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
- I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. “toggleReport” and not “onIconClick”)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct english, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
- I verified any copy / text shown in the product was added in all
src/languages/*
files - I verified any copy / text that was added to the app is correct english and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in
STYLE.md
) were followed
- If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
- I followed the guidelines as stated in the Review Guidelines
- I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like
Avatar
, I verified the components usingAvatar
are working as expected) - I verified all code is DRY
- I verified any variables that can be defined as constants (ie. in CONST.js) are defined as such
- If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a
/** comment above it */
- Any functional components have the
displayName
property - The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- Any internal methods are bound to “this” properly so there are no scoping issues
- Any internal methods bound to “this” are necessary to be bound
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose and it is
- If a new CSS style is added I verified that:
- A similar style doesn’t already exist
- The style can’t be created with an existing StyleUtils function
(i.e.StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)
🎀 👀 🎀 C+ reviewed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you guys for your efforts!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by @marcochavezf in version: 1.1.51-0 🚀
|
🚀 Deployed to production by @roryabraham in version: 1.1.51-0 🚀
|
🚀 Deployed to production by @roryabraham in version: 1.1.51-0 🚀
|
Details
The issue is happen because when finding a
policy
by id frompolicies
, thepolicies
has potentialnull
data. So the solution is to check ifpolicy
frompolicies
isnull
then we skip it.Fixed Issues
$ #8033
Tests
PR Review Checklist
Contributor (PR Author) Checklist
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
filesSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
displayName
propertythis
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)PR Reviewer Checklist
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and notonIconClick
).src/languages/*
filesSTYLE.md
) were followed/** comment above it */
displayName
propertythis
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)QA Steps
Screenshots
Web
Screen.Recording.2022-04-01.at.09.44.06.mov
Mobile Web
Screen.Recording.2022-04-01.at.09.44.41.mov
Screen.Recording.2022-04-01.at.09.45.12.mov
Desktop
Screen.Recording.2022-04-01.at.10.53.27.mov
iOS
Screen.Recording.2022-04-01.at.10.55.45.mov
Android
Screen.Recording.2022-04-01.at.10.56.20.mov