-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Commenting out the confimation modal to test something in staging." #8892
Revert "Commenting out the confimation modal to test something in staging." #8892
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Two questions:
- What were the results of the test?
- Does this PR need to be CP'd as well?
The result of the test was that the issue was still ocurring. And the changes seems to have no effect on the issue. This was an exploratory PR due to the ficulties of testing this on dev. (edit) forgo that I could add the CP label |
|
Triggered auto assignment to @joelbettner ( |
@MariaHCD looks like this was merged without passing tests. Please add a note explaining why this was done and remove the |
Merged since this was a straight revert. |
…onfimation_workspace Revert "Commenting out the confimation modal to test something in staging." (cherry picked from commit a29cdc2)
…8892 🍒 Cherry pick PR #8892 to staging 🍒
🚀 Cherry-picked to staging by @MariaHCD in version: 1.1.57-7 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
Reverts #8882
It did not fix #8791 reverting