Testing no dots and assistance button #8906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
chiragsalian
changed the title
chiragsalian
changed the title
francoisl
approved these changes
May 9, 2022
OSBotify
pushed a commit
that referenced
this pull request
May 9, 2022
Testing no dots and assistance button (cherry picked from commit 24aa0b0)
OSBotify
added a commit
that referenced
this pull request
May 9, 2022
…8906 🍒 Cherry pick PR #8906 to staging 🍒
|
Did not work on staging. Here is the first screen with apple smartpopover, Here is the second screen once i click into the workspace, |
|
🚀 Cherry-picked to staging by @chiragsalian in version: 1.1.57-9 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
This was referenced May 10, 2022
|
🚀 Deployed to production by @chiragsalian in version: 1.1.57-17 🚀
|
64 tasks
This was referenced May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Fixed Issues
$ #8791
Tests
None. I've just removed the dots and assistance button from this view to see if it helps with the original issue.
Can only be tested on staging so once i test on staging i'll revert this code.