Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Keep focus on textinput field after pressing enter when button is disabled" #8953

Merged
merged 1 commit into from
May 11, 2022

Conversation

chiragsalian
Copy link
Contributor

@chiragsalian chiragsalian commented May 11, 2022

Reverts #8591

That PR caused as issue so i'm reverting it. I tested the reported issue steps mentioned here and confirm its resolved.

@chiragsalian chiragsalian self-assigned this May 11, 2022
@chiragsalian chiragsalian marked this pull request as ready for review May 11, 2022 21:43
@chiragsalian chiragsalian requested a review from a team as a code owner May 11, 2022 21:43
@melvin-bot melvin-bot bot requested review from marcochavezf and removed request for a team May 11, 2022 21:43
@github-actions
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

Copy link
Contributor

@luacmartins luacmartins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@luacmartins luacmartins merged commit 1dca77a into main May 11, 2022
@luacmartins luacmartins deleted the revert-8591-sn_bug-iouamountpage-return-key branch May 11, 2022 21:46
@melvin-bot
Copy link

melvin-bot bot commented May 11, 2022

@luacmartins looks like this was merged without passing tests. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@melvin-bot melvin-bot bot added the Emergency label May 11, 2022
@luacmartins
Copy link
Contributor

Tests were passing when the PR was merged. Removing Emergency label.

OSBotify pushed a commit that referenced this pull request May 11, 2022
…age-return-key

Revert "Keep focus on textinput field after pressing enter when button is disabled"

(cherry picked from commit 1dca77a)
OSBotify added a commit that referenced this pull request May 11, 2022
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by @luacmartins in version: 1.1.57-14 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @chiragsalian in version: 1.1.57-17 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants