Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spacing in compose metadata #9206

Merged
merged 1 commit into from
May 27, 2022
Merged

Conversation

amyevans
Copy link
Contributor

cc @Luke9389

Details

Fixes spacing in the compose metadata area

Fixed Issues

$ #9205

Tests / QA

  1. Open a chat
  2. Go offline
  3. Verify the offline message now appears above the compose input
  4. Go back online
  5. Compose a message with more than 60,000 characters (use copy/paste to do this easily)
  6. Verify the comment exceeded meta data is displayed above the compose input
  7. Open a second incognito browser and sign in as the other chat participant and start typing
  8. Verify that the "user is typing" message is above the compose input
  9. Open a third incognito browser and sign in as a third chat participant
  10. Start a group chat with all three people
  11. Quickly type something in the compose input in two of the browsers
  12. Verify that in the third browser the "multiple people are typing" appears and it's displayed above the compose input
  13. Verify that all the vertical and horizontal spacing looks OK
  • Verify that no errors appear in the JS console

Screenshots

Web

web

Mobile Web

mobile-web

Desktop

desktop

iOS

ios

Android

android

@amyevans amyevans requested a review from Luke9389 May 27, 2022 20:39
@amyevans amyevans requested a review from a team as a code owner May 27, 2022 20:39
@amyevans amyevans self-assigned this May 27, 2022
@melvin-bot melvin-bot bot requested review from danieldoglas and removed request for a team May 27, 2022 20:39
Copy link
Contributor

@Luke9389 Luke9389 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks

@Luke9389 Luke9389 merged commit 1d58296 into main May 27, 2022
@Luke9389 Luke9389 deleted the amy-compose-metadata-styling branch May 27, 2022 21:52
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @Luke9389 in version: 1.1.69-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @luacmartins in version: 1.1.69-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants