-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update electron-notarize
and use new notary tool
#9295
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's try it!
(cherry picked from commit 9c2ab34)
…9295 🍒 Cherry pick PR #9295 to staging 🍒
Hmm so it's failing with Seems like the correct team ID is |
Good idea, see #9299 ! |
🚀 Cherry-picked to staging by @roryabraham in version: 1.1.70-4 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to production by @yuwenmemon in version: 1.1.71-2 🚀
|
Details
Updated
electron-notarize
which now uses an app password instead of account password, which should allow us to skip 2FA checks which were I believe causing notary errors.Fixed Issues
$ #9277
Tests