Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[No QA] Report_AddComment Refactor Part 1 #9328

Merged
merged 4 commits into from
Jun 7, 2022
Merged

[No QA] Report_AddComment Refactor Part 1 #9328

merged 4 commits into from
Jun 7, 2022

Commits on Jun 7, 2022

  1. Move the notification logic into its own method 

    Use timestamp based solution to determine if we need to send a notification

set notificationPreference in report object

Use notification preference from Pusher for now

improve comment

Get rid of sendLocalNotification and just perform directly in Onyx.connect

change name to viewNewReportAction

Make a better diff

Fix tests
    @marcaaron
    marcaaron committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    0b0616d View commit details
    Browse the repository at this point in the history

  2. woopsies

    @marcaaron
    marcaaron committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    71152fe View commit details
    Browse the repository at this point in the history

  3. Use hasAttemptedToNotify

    @marcaaron
    marcaaron committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    856015a View commit details
    Browse the repository at this point in the history

  4. remove hasAttemptedToNotify because it doesnt seem to work

    @marcaaron
    marcaaron committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    a6910e7 View commit details
    Browse the repository at this point in the history