[No QA] Make use of CONST for pusher channels. #9373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 9, 2022 13:04
|
@Luke9389 FYI conflicts |
|
Updated to remove merge conflict |
Julesssss
approved these changes
Jun 14, 2022
8 tasks
|
🚀 Deployed to staging by @Julesssss in version: 1.1.77-1 🚀
|
|
🚀 Deployed to production by @roryabraham in version: 1.1.77-2 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
I was looking into our pusher authentication when reviewing the App Start / Reconnect API Refactors Doc and noticed that we were not being consistent about our usage of pusher channel constants. One was defined but only used once, and the other channel (reports) had no const at all.