-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the InternalQA checklist loosing its state #9458
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice find!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
@mountiny can you add some manual testing steps please? Maybe just:
|
Triggered auto assignment to @yuwenmemon ( |
🚀 Deployed to staging by @yuwenmemon in version: 1.1.78-0 🚀
|
Good shout, thanks Rory! |
Indeed something must be wrong with the regex, tested if the state of the checkbox has been kept and it was not: #9565 |
Good, I think I found what needs to be done to get this over the finish line. |
@mountiny @yuwenmemon to confirm, there's no QA to do for this, right? |
@francoisl the QA has failed unfortunately but Rory put up a fix. I am working on a follow up as the state of the checkboxes is still being lost, but this is fine for the deploy! |
🚀 Deployed to production by @sketchydroide in version: 1.1.78-8 🚀
|
cc @yuwenmemon would you want to review, please? :)
Details
We were missing passing into the array of PRs those which have internalQA label, we did not parse the InternalQA section as we do for the deploy blockers.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/198446
Tests
Automated tests already exist, they were false negatives previously showing this works although it did not work. Now they are true negatives as it should actually work.