Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] Remove @react-native-community/cli Dependency #9468

Merged
merged 2 commits into from
Jun 15, 2022

Conversation

Luke9389
Copy link
Contributor

Details

This PR just removes a dependency that was not needed.

Related Issues

#9427

Tests

Verify that the app still builds locally.

Web QA

All that's needed here is to ensure the app still builds, which would get caught by regression tests (obviously), so this is No QA.

@Luke9389 Luke9389 self-assigned this Jun 15, 2022
@Luke9389 Luke9389 requested a review from a team as a code owner June 15, 2022 17:49
@Luke9389 Luke9389 changed the title Luke remove rncli dep [No QA] Remove @react-native-community/cli Dependency Jun 15, 2022
@melvin-bot melvin-bot bot requested review from stitesExpensify and removed request for a team June 15, 2022 17:49
@stitesExpensify stitesExpensify merged commit 07fabcf into main Jun 15, 2022
@stitesExpensify stitesExpensify deleted the luke-remove-rncli-dep branch June 15, 2022 19:34
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @stitesExpensify in version: 1.1.78-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @sketchydroide in version: 1.1.78-8 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants