Fix regex in getStagingDeployCashInternalQA #9523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francoisl
reviewed
Jun 21, 2022
| [...internalQASection.matchAll(new RegExp(`- \\[([ x])]\\s(${ISSUE_OR_PULL_REQUEST_REGEX.source})`, 'g'))], | ||
| [...internalQASection.matchAll(new RegExp(`- \\[([ x])]\\s(${PULL_REQUEST_REGEX.source})`, 'g'))], |
There was a problem hiding this comment.
For this one specifically, shouldn't we keep ISSUE_OR_PULL_REQUEST_REGEX?
There was a problem hiding this comment.
Oh no nevermind, it's only used in getStagingDeployCashPRList where we only care about PRs.
francoisl
approved these changes
Jun 21, 2022
50 tasks
|
This fixed the workflow but it appears that the internalQA checkbox lost it's state? cc @mountiny |
|
🚀 Deployed to staging by @francoisl in version: 1.1.78-5 🚀
|
|
Ahhh, some bad copypasta! Thanks for the quick fix Rory! |
|
🚀 Deployed to production by @sketchydroide in version: 1.1.78-8 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This just fixes the regex in
getStagingDeployCashInternalQAso that it doesn't pick up deploy blockers beneath. Tested with https://regexr.com/Fixed Issues
$ #9500
Tests
QA Steps
preDeploy.ymlworkflow should succeed.