Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Edit and Delete Report Comment #9532
Refactor Edit and Delete Report Comment #9532
Changes from all commits
827e0cf
47f54ac
82309d7
5cd5c15
3246ff7
8f23138
30991b5
483b78b
0da2900
f8bf959
e4d3b9f
4c8f633
8de9a89
63219b8
52d6960
39c06b6
f42ae84
554e247
818be57
769d43e
1ee29e6
53ae16a
2c808ce
62401ee
afc8fc6
c12fcd1
1888216
22f5e1b
27c5bc9
3b3d43d
6afbf4a
b633c47
bfc8584
2e70d47
fc0803b
c000554
d57dd14
27361a7
f06eac4
7dc9e3f
bb0f552
4bce6bf
5f713be
ee002be
03115f8
b715aed
bcc2b66
69ba9f2
9a5b5bd
70ef475
545977e
dd41dad
ab9772f
e2bbed7
26d2704
b20e330
c9cc3b8
98c3ed3
90ae734
d0784e4
82c150b
6535d05
68a32c7
f8146dd
70b383f
219dae4
493768a
c335b0a
c498a35
e0cc84b
7c5a71a
b6a179e
d2f86c2
a41fa84
2fb375c
765b0d8
0c3e9ce
91841dc
827ad50
0e0376c
e076529
fb063f0
70f6d27
093bc57
c39972a
542d0e1
2f9de3d
764a569
b5b7fb3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe could use a comment here to explain why we need to update the
lastMessageText
here? Is it only necessary when we are deleting the last visible message?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also I think this should be passing in the modified message.. like:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not that sure we need all that anymore except for the
unreadActionCount
bits! Things weren't so clear for me when I started working on the app :pThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nah, I think we do need. Not sure why though, I thought the API would update lastMessageText for the sender and recipient. Need some more time to understand everything