Fix combobox minimize #9706

mollfpr · 2022-07-05T17:47:19Z

Details

Adding history router with type drawer to only when on mobile. On web or desktop size we don't need the drawer to toggle.

Fixed Issues

$ #8841

Tests

Click on one chat first
Minimize the window as much as possible
Maximize the window
Click another chat
Minimize window
Verify that the report screen is showing when minimizing the window

Verify that no errors appear in the JS console

PR Review Checklist

Contributor (PR Author) Checklist

PR Reviewer Checklist

QA Steps

Click on one chat first
Minimize the window as much as possible
Maximize the window
Click another chat
Minimize window
Verify that the report screen is showing when minimizing the window

Verify that no errors appear in the JS console

Screenshots

Web

screen-recording-2022-07-05-at-232433_9Fiwh2QP.mp4

Mobile Web

screen-recording-2022-07-05-at-232932_kwktq1nb.mp4

screen-recording-2022-07-05-at-232527_N2pCHoto.mp4

Desktop

screen-recording-2022-07-05-at-233053_P9Cvk1K0.mp4

iOS

Screen.Recording.2022-07-06.at.22.48.41.mov

Android

…ox-minimize

mollfpr · 2022-07-06T16:40:20Z

@Santhosh-Sellavel Can you help me to test on Android native? I can't run the android on my local. Thanks!

aldo-expensify · 2022-07-06T18:47:52Z

src/libs/Navigation/Navigation.js

 * @returns {String}
 */
-function getDefaultDrawerState(isSmallScreenWidth) {
+function getDefaultDrawerState(isSmallScreen) {
+    isSmallScreenWidth = isSmallScreen;


This getter having a side effect of setting isSmallScreenWidth feels too dirty. navigate calling navigationRef.current.dispatch(CustomActions.pushDrawerRoute(route, isSmallScreenWidth)); depends on getDefaultDrawerState having been called before.

Are we okay using your approach to get the dimension?

const initialDimensions = Dimensions.get('window'); const isSmallScreenWidth = initialDimensions.width <= variables.mobileResponsiveWidthBreakpoint;

I couldn't find another way to get the screen size except using Dimensions.

This is what I came with when I was testing, I didn't see any other way that didn't involve changing too many things (I must say I didn't tried much :P)

Thoughts @Santhosh-Sellavel ?

Isn't there any API in Dimensions to listen to the changes? @mollfpr Explore the options.

I may be missing something, but if that code is inside pushDrawerRoute, wouldn't it be up to date when that function is called? pushDrawerRoute doesn't get called when minimizing or expanding the window, does it?

Yep, that should do.

Yep, that should do.

@aldo-expensify I already confirmed it would work.

Yep, that should do.

@aldo-expensify I already confirmed it would work.

The version with the listener?

Are we okay using your approach to get the dimension?

const initialDimensions = Dimensions.get('window'); const isSmallScreenWidth = initialDimensions.width <= variables.mobileResponsiveWidthBreakpoint;

Sorry for the confusion, I thought we are determining once. This way itself will work if it is determined every time.
@aldo-expensify

mollfpr · 2022-07-13T18:27:44Z

src/libs/Navigation/CustomActions.js

+Dimensions.addEventListener('change', ({window}) => {
+    isSmallScreenWidth = window.width <= variables.mobileResponsiveWidthBreakpoint;
+});
+


@Santhosh-Sellavel @aldo-expensify I adding a listener to get the screen size. It's should reflect the screen size.

hum, I still don't understand how Dimensions.get('window'); would be outdated. From the documentation it looks like it should return the current width, up to date when is used by pushDrawerRoute.

I don't think this is necessary at all.

@Santhosh-Sellavel can you explain more why you think it would "not reflect correctly"?

So let's go with the first way right @aldo-expensify or let's keep this? I'll leave it to you to decide.

Thanks @Santhosh-Sellavel , I got a bit confused in the other conversation :P

Considering that the "first way" worked fine, I prefer the first way because it is more simple than keeping this variable up to date with a listener. Can you revert this last commit introducing the listener?

Cool! @mollfpr kindly update the PR

mollfpr · 2022-07-15T17:17:06Z

@aldo-expensify @Santhosh-Sellavel updated!

Santhosh-Sellavel · 2022-07-15T18:22:20Z

@Santhosh-Sellavel Can you help me to test on Android native? I can't run the android on my local. Thanks!

What issue you are facing in the local?

Santhosh-Sellavel · 2022-07-15T19:09:35Z

@mollfpr
We have a breakage here

Steps:

Open the app in the expanded window.
Click any chat
Minimize the window
Click back from the chat header
Try to switch to a different chat but it's not working.

Bug1.mov

cc: @aldo-expensify

aldo-expensify · 2022-07-15T23:00:44Z

@Santhosh-Sellavel I tried to reproduce the problem you see, but didn't happen to me. Does it always happen to you? or sometimes? can you check if you don't have the same problem in main?

Santhosh-Sellavel · 2022-07-16T01:52:31Z

I pulled from main and made the changes.

…ox-minimize

mollfpr · 2022-07-17T17:38:19Z

@Santhosh-Sellavel I'm unable to produce the above issue.

Santhosh-Sellavel · 2022-07-18T16:59:24Z

Reviewing again now.

Santhosh-Sellavel · 2022-07-18T17:12:50Z

@Santhosh-Sellavel Can you help me to test on Android native? I can't run the android on my local. Thanks!

What issue you are facing in the local?

@mollfpr

Santhosh-Sellavel · 2022-07-18T17:13:27Z

@Santhosh-Sellavel I tried to reproduce the problem you see, but didn't happen to me. Does it always happen to you? or sometimes? can you check if you don't have the same problem in main?

Pulled changes again today. Not reproducible now. But I'm afraid this might be a regression where I'm missing exact steps to reproduce now.

aldo-expensify

Tested again and it seems to work fine.

I'll get another pair of eyes just to be sure.

mollfpr · 2022-07-21T03:01:51Z

What issue you are facing in the local?

I think it’s because I update my Java to 17, I did’nt have enough time to fix the JDK. Btw I’m using apple chip.

Justicea83

LGTM!

Santhosh-Sellavel · 2022-07-24T13:33:43Z

PR Reviewer Checklist

I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- Any functional components have the displayName property
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn’t already exist
- The style can’t be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.

Santhosh-Sellavel

Looks good to me!

aldo-expensify · 2022-07-25T18:06:05Z

thanks for reviewing again @Santhosh-Sellavel !

OSBotify · 2022-07-25T18:13:22Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

marcaaron · 2022-07-26T00:48:57Z

I do wish that a broader conversation would have been started about this PR and solution. Almost every issue dealing with react-navigation was put on hold a while back while so we could look at longer term more holistic solutions. This one still made it through somehow...

@Santhosh-Sellavel please recall these posts (maybe you have not seen them)

https://expensify.slack.com/archives/C02NK2DQWUX/p1652908236507109
https://expensify.slack.com/archives/C02NK2DQWUX/p1653333895007009

@aldo-expensify I'm not sure what I could have done differently here and not casting any blame for accepting this solution. Maybe I could have been more proactive here or there is some way to lock the file so it won't be edited anymore.

…ions2 [No QA] Revert #9706. Rename file to `DeprecatedCustomActions.js` to prevent further editing

OSBotify · 2022-08-01T22:40:06Z

🚀 Deployed to staging by @aldo-expensify in version: 1.1.87-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	failure ❌
🕸 web 🕸	failure ❌

OSBotify · 2022-08-04T20:52:09Z

🚀 Deployed to production by @yuwenmemon in version: 1.1.87-9 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

mollfpr added 2 commits July 5, 2022 23:24

adding history route for instead history drawer on big screen

ad7af73

Merge branch 'main' of https://github.com/mollfpr/App into fix-combob…

bf464a2

…ox-minimize

mollfpr marked this pull request as ready for review July 6, 2022 16:39

mollfpr requested a review from a team as a code owner July 6, 2022 16:39

melvin-bot bot requested review from aldo-expensify and Santhosh-Sellavel and removed request for a team July 6, 2022 16:39

aldo-expensify requested changes Jul 6, 2022

View reviewed changes

update how to get screen size

1d8f437

mollfpr commented Jul 13, 2022

View reviewed changes

update small screen value

a9fde46

Merge branch 'main' of https://github.com/mollfpr/App into fix-combob…

10dd87a

…ox-minimize

aldo-expensify approved these changes Jul 21, 2022

View reviewed changes

aldo-expensify mentioned this pull request Jul 21, 2022

[HOLD for payment 2022-08-11] [HOLD] [$1000] Web - Compose Box - In Minimize window one chat goes to the list of chats #8841

Closed

Justicea83 approved these changes Jul 21, 2022

View reviewed changes

Santhosh-Sellavel approved these changes Jul 24, 2022

View reviewed changes

aldo-expensify merged commit c5fb877 into Expensify:main Jul 25, 2022

marcaaron added a commit that referenced this pull request Jul 26, 2022

Revert changes made in #9706

5f16ef9

marcaaron added a commit that referenced this pull request Jul 26, 2022

Merge pull request #10101 from Expensify/marcaaron-deprecateCustomAct…

7ac50ce

…ions2 [No QA] Revert #9706. Rename file to `DeprecatedCustomActions.js` to prevent further editing

OSBotify mentioned this pull request Aug 1, 2022

Deploy Checklist: New Expensify 2022-08-01 #10169

Closed

95 tasks

kavimuru mentioned this pull request Aug 4, 2022

[HOLD][$250] Web - Compose Box - In the minimize window, one chat opens with weird behavior #10243

Closed

Fix combobox minimize #9706

Fix combobox minimize #9706

Conversation

mollfpr commented Jul 5, 2022 • edited Loading

Details

Fixed Issues

Tests

PR Review Checklist

Contributor (PR Author) Checklist

PR Reviewer Checklist

QA Steps

Screenshots

Web

Mobile Web

Desktop

iOS

Android

mollfpr commented Jul 6, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aldo-expensify Jul 15, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mollfpr commented Jul 15, 2022

Santhosh-Sellavel commented Jul 15, 2022

Santhosh-Sellavel commented Jul 15, 2022

aldo-expensify commented Jul 15, 2022

Santhosh-Sellavel commented Jul 16, 2022

mollfpr commented Jul 17, 2022

Santhosh-Sellavel commented Jul 18, 2022

Santhosh-Sellavel commented Jul 18, 2022

Santhosh-Sellavel commented Jul 18, 2022 • edited Loading

aldo-expensify left a comment

Choose a reason for hiding this comment

mollfpr commented Jul 21, 2022

Justicea83 left a comment

Choose a reason for hiding this comment

Santhosh-Sellavel commented Jul 24, 2022

PR Reviewer Checklist

Santhosh-Sellavel left a comment

Choose a reason for hiding this comment

aldo-expensify commented Jul 25, 2022

OSBotify commented Jul 25, 2022

marcaaron commented Jul 26, 2022

OSBotify commented Aug 1, 2022

OSBotify commented Aug 4, 2022

mollfpr commented Jul 5, 2022 •

edited

Loading

aldo-expensify Jul 15, 2022 •

edited

Loading

Santhosh-Sellavel commented Jul 18, 2022 •

edited

Loading