Clean up `lastReadSequenceNumbers` and `reportMaxSequenceNumbers` #9755

marcaaron · 2022-07-07T03:38:39Z

Details

Quick draft to explore getting rid of these two "maps" of local variables that we have.

They are making it kind of hard to reason about our "optimistic" updates that need to be made and ideally we would be able to control these things from the server. So a first step is to keep referencing them on the report object instead of in these maps.

Also tried to clean up the logic around setting unreadActionCount as I noticed that the setLocalLastRead() method was being used sometimes to update the lastReadSequenceNumbers directly (which just seems wrong) but it also performed a confusing side effect of updating the unreadActionCount which also seems wrong and made it difficult to tell what things are updating the unreadActionCount at all.

Fixed Issues

(Related to both of these since the setting of unreads is pretty wonky atm)

https://github.com/Expensify/Expensify/issues/212871
https://github.com/Expensify/Expensify/issues/211601

Tests & QA

Test unread action shows

As User A start a chat with User B
Navigate to a different chat so it it out of view
As User B leave a comment
As User A verify the chat is bold in the LHN
Navigate to the chat
Verify the chat no longer displays as "unread" in the LHN
Navigate away to a new chat and back again
Verify the new marker has disappeared

2022-07-07_14-49-29.mp4

Note: Also verify a browser notification shows on Desktop and Web (not mobile web)

Test unread action does not show when report is active

As User A start a chat with User B
Stay navigated on the chat and do not navigate to another chat
As User B leave a comment
As User A verify the chat is not bolded

2022-07-07_14-53-37.mp4

Manually marking chat works as expected

Start with a chat that has no deleted items at all and several messages
Manually mark a message as "unread"
Verify the green floating counter badge shows the correct number of unreads
Verify the chat is shown bold in the LHN
Verify the new marker shows in the correct location

2022-07-07_14-56-28.mp4

Deleted comments behave as expected when calculating unreads and lastMessageText

Start with a chat that has no deleted items at all and several messages from the current user at the bottom
Manually mark a message as "unread"
Verify the green floating badge shows the correct number of unreads
Verify the chat is shown bold in the LHN
Verify the new marker shows in the correct location
Delete a chat message that is older than the message marked as unread
Verify it has no impact on the global chat counter or floating green badge
Verify it does not mark the report as read
Verify the "last message text" in the LHN associated with the chat is correct (it should still be the last message)
Delete a chat message that is more recent than the last read but not the very last message
Verify the floating green counter decreases by one
Verify the report is still marked as "unread"
Delete the last message and verify the previous 3 steps, but also verify the last message text updates correctly and should be the message before the deleted one.

2022-07-07_15-09-52.mp4

Test tapping green message counter will reset new marker line and mark report as read

Add a bunch of comments to a report
Mark a comment in the middle as unread
Scroll up to reveal the floating green counter button
Tap it
Verify the report scrolls to the bottom
Verify the report is marked as "read"
Verify the new marker is removed

2022-07-07_15-14-16.mp4

Verify that no errors appear in the JS console

PR Review Checklist

Contributor (PR Author) Checklist

PR Reviewer Checklist

Note: Tested on all platforms, but not posting videos since there are no UI changes.

marcaaron · 2022-07-07T03:58:33Z

cc @madmax330 @tgolen

Coming from this comment thread... I wanted to start a big conversation about this stuff, but as I started to write it all down it became clear that it might be easier to just suss out a few ideas in a PR review first...

My ultimate goal is to get rid of this block of code here:

App/src/libs/actions/Report.js

Lines 1407 to 1420 in eb54f23

    
           // When handling an action from the current users we can assume that their 
        
           // last read actionID has been updated in the server but not necessarily reflected 
        
           // locally so we must first update it and then calculate the unread (which should be 0) 
        
           if (isFromCurrentUser) { 
        
               setLocalLastRead(reportID, newMaxSequenceNumber); 
        
           } 
        
           const updatedReportObject = { 
        
               // Use updated lastReadSequenceNumber, value may have been modified by setLocalLastRead 
        
               // Here deletedComments count does not include the new action being added. We can safely assume that newly received action is not deleted. 
        
               unreadActionCount: newMaxSequenceNumber - (lastReadSequenceNumbers[reportID] || 0) - ReportActions.getDeletedCommentsCount(reportID, lastReadSequenceNumbers[reportID] || 0), 
        
           }; 
        
           Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}${reportID}`, updatedReportObject);

But getting rid of setLocalLastRead() requires the changes in this PR. So I wanted to unwind some of this first and then get some more 👀 on how to get rid of the side effect here that updates the unreadActionCount of a report.

At a high level it looks like we do this:

New comment appears for a report
A. If it's from the current user we set the unreadActionCount for the report to 0 (hopefully)
B. If it's not from the current user we recalculate the unreadActionCount based on the new sequence number

Getting rid of A seems easy enough. Just set the lastReadSequenceNumber and unreadActionCount in the server because the user just left a new comment on a report.

B is a little trickier because when sending out updates to participants you'd need to calculate the "unread" like we are doing in the frontend and then push that out as an onyx update. This process in the server would probably look something like:

Get each participant's lastRead_<accountID> rNVP for the report where a comment is added
Also get the number of "deleted comments" in the range between lastReadSequenceNumber and maxSequenceNumber
Calculate the unreadActionCount and push each clients unique value to them

I can't really think of any reason why that would not work, but feel like I'm missing something.

Regardless, I think some changes like I've got in this PR would be a good "stepping" stone since the setLocalLastRead() method is causing some confusion in the places where we are trying to refactor it away.

tgolen · 2022-07-07T15:54:30Z

Hey Marc,

I like the direction this is doing in. It already feels cleaner and I love the removal of setLocalLastRead().

I know I'm not as close to this code as you are, so I don't have a full understanding over all the logic that exists. Hopefully, I can offer somewhat of an outsider perspective with my next suggestion.

Getting rid of A seems easy enough. Just set the lastReadSequenceNumber and unreadActionCount in the server because the user just left a new comment on a report.

This makes sense to me 👍

B is a little trickier because when sending out updates to participants you'd need to calculate the "unread" like we are doing in the frontend

My out-of-the-box idea here is that maybe instead of pushing out the unread count for each participant, we push out an event that is basically "increment the unread count for report ID: X". That way there doesn't really need to be any math or calculations done. We just know that there is a new comment for the report, and until the comment is explicitly seen, we know it should just increment the participants counter by 1.

That works if everyone is online and connected to pusher. If a participant is not connected to pusher, the next time they connect, the front-end (or maybe the server) should still be able to calculate the unread count properly.

Thoughts about that approach?

madmax330 · 2022-07-07T16:15:57Z

Same as Tim I agree with A.

For B I like the event idea, but we'd also have to have an event for deleted chats no? Depending on whether you're deleting a chat that has been read already or not.

Another idea is:

The unread count should always be lastReadSequenceNumber - maxSequenceNumber that way it's super simple.
How that would work is, when we get chats we ignore the deleted ones, so they're not included in the maxSequenceNumber.
When we delete a chat, we just decrement maxSequenceNumber and lastReadSequenceNumber b/c that's basically what will happen on the server.
To account for deleted chats that may or may not have been read. We do deletedSequenceNumber > lastRead ? decrementBoth() : decrementMaxSequenceNumber()

Basically we're optimistically predicting the changes in the sequenceNumber from the server response.

madmax330 · 2022-07-07T16:53:49Z

Or even simpler, this might be a naive question, but why can't we just count the number of actions after the lastReadSequenceNumber that aren't deleted?

marcaaron · 2022-07-07T17:16:20Z

Oh wow, nice, I really love both of these ideas!

@tgolen I like this because we can essentially stop tracking maxSequenceNumber altogether and avoid any calculations in the client (I think we still need lastReadSequenceNumber for the "new marker", but we can stop using the maxSequenceNumber - which seems exclusively used to calculate the "unread count").

That way there doesn't really need to be any math or calculations done. We just know that there is a new comment for the report, and until the comment is explicitly seen, we know it should just increment the participants counter by 1.

Very cool, so something like:

Fetch initial report -> user starts with base count from server
Report action deleted optimistically -> count--
Report action failed to be deleted (rollback) -> count++
New action appears from current user -> reset count to 0
New action appears from a different user -> count++

We could let the server send out these "increment" or "decrement" instructions that way we don't have to have specific events to track "new comment" vs "deleted comment" and could just do stuff like:

[
    'onyxMethod' => 'merge',
    'key' => 'report_1',
    'value' => [
        'unreadActionCount' => '++',
    ],
],

Not sure if we want something like that or something simpler like just having an event like updateReportUnreadCount that sends a payload like:

[
    'action' => 'increment'
    'reportID' => 1, 
],

@madmax330 your idea sounds nice since we won't need specific events to tell the client to increment or decrement. But it seems like in practice we could have something like this...

0 - deleted
1 - deleted
2 - deleted
3 - deleted
4 - Comment 1
5 - Comment 2 (last read)
6 - Comment 3

and the last read would be 5 but the maxSequenceNumber would be 2? But maybe you are saying that in this case the lastReadSequenceNumber would not be 5 and would be 1 - which would give us a count of 1 unread.

The only potential issue I see with this is that when modifying the lastReadSequenceNumber we would need to figure out where to position the "new marker" since the report actions themselves are not having their sequenceNumber decremented when things are deleted.

Or even simpler, this might be a naive question, but why can't we just count the number of actions after the lastReadSequenceNumber that aren't deleted?

The problem with counting the report actions themselves is that they might not exist at all locally.

madmax330 · 2022-07-07T17:21:48Z

The problem with counting the report actions themselves is that they might not exist at all locally.

Can you elaborate on this? Why wouldn't they?

marcaaron · 2022-07-07T17:24:15Z

Can you elaborate on this? Why wouldn't they?

Because they are paginated and we only download a subset of the chats you have when the app starts not all of your chats and chat messages. They can also get "evicted" if we run out of device storage but that is rarer now (especially on web)

madmax330 · 2022-07-07T17:30:46Z

Because they are paginated and we only download a subset of the chats you have when the app starts

This is only an issue if you have more unreads than the page size though right?
And it's also an issue for all the other solution as well right? Because before incrementing or decrementing we have to base ourselves on something to get the initial count. That something being the reportActions. Or am I missing something?

They can also get "evicted" if we run out of device storage but that is rarer now (especially on web)

Yeah I'm not sure how to deal with this.

marcaaron · 2022-07-07T17:37:56Z

This is only an issue if you have more unreads than the page size though right?

Yes, to use the reportActions alone we'd need to have all the chat messages for all the chats from the "last read" to the "most recent".

And it's also an issue for all the other solution as well right? Because before incrementing or decrementing we have to base ourselves on something to get the initial count. That something being the reportActions. Or am I missing something?

unreadActionCount is always initially based on the lastReadSequenceNumber and number of report actions (we return a reportActionCount from Auth and know this without having to count the actions themselves in the frontend).

tgolen · 2022-07-07T18:45:27Z

Yes, to use the reportActions alone we'd need to have all the chat messages for all the chats from the "last read" to the "most recent".

Just a quick thought on this... it actually sounds like that could be an improvement to our pagination. Instead of always getting the 50 most recent chats for the first page, the first page could be either the 50 most recent OR all the chats since "last read".

I love this! ❤️ Slight tweak below in bold is needed (I think)

Very cool, so something like:

Fetch initial report -> user starts with base count from server
Report action deleted optimistically -> count--
Report action failed to be deleted (rollback) -> count++
New action appears from current user -> reset count to 0
New action appears from a different user -> count++
Action is deleted from a different user -> count-- (?) I'm not exactly sure what would happen here

Not sure if we want something like that or something simpler like just having an event like updateReportUnreadCount that sends a payload like:

I'd vote for something like that ^, yeah. I think the other option just makes it a little too magical and I fear it could wreak havoc in unexpected ways at some point without knowing it.

marcaaron · 2022-07-07T18:54:09Z

Action is deleted from a different user -> count-- (?) I'm not exactly sure what would happen here

Oh yes, actually I think if an action is deleted by any user we would still need to look at the lastReadSequenceNumber to decide what to do...

action deleted has a sequenceNumber > the lastReadSequenceNumber -> count--
action deleted has a sequenceNumber < the lastReadSequenceNumber -> do nothing since only actions greater than the lastReadSequenceNumber would affect the count

marcaaron · 2022-07-07T19:05:18Z

Just a quick thought on this... it actually sounds like that could be an improvement to our pagination. Instead of always getting the 50 most recent chats for the first page, the first page could be either the 50 most recent OR all the chats since "last read".

We could possibly send out paginated report actions with every new comment that gets added...

e.g.

User A has no chat messages locally stored for a chat with User B (the chat itself has 200 historical messages)
The last message User A read was sequenceNumber 50
User B sends a new message with sequenceNumber 201
In the server, we look at User A's last read recorded and send every message from 50 - 201 to User A
User A can now figure out that their unread count based on actions alone

tgolen · 2022-07-07T19:08:19Z

Oh, that's pretty interesting. Sounds a little more complex, but it sounds like it could definitely work.

…

On Thu, Jul 7, 2022 at 1:05 PM Marc Glasser ***@***.***> wrote: Just a quick thought on this... it actually sounds like that could be an improvement to our pagination. Instead of always getting the 50 most recent chats for the first page, the first page could be either the 50 most recent OR all the chats since "last read". We could possibly send out paginated report actions with every new comment that gets added... e.g. - User A has no chat messages locally stored for a chat with User B (the chat itself has 200 historical messages) - The last message User A read was sequenceNumber 50 - User B sends a new message with sequenceNumber 201 - In the server, we look at User A's last read recorded and send every message from 50 - 201 to User A - User A can now figure out that their unread count based on actions alone — Reply to this email directly, view it on GitHub <#9755 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJMAB6BRANB6O2ZVUGOYJDVS4S7TANCNFSM5233LPCA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

marcaaron · 2022-07-07T19:48:36Z

Ah came across an edge case where we need to calculate the unreads in the client based on the deleted report actions 😄

When a user manually marks a comment as “unread” we will have to use the report actions to "optimistically determine" the unread count since we don’t know how many deleted comments are between the lastReadSequenceNumber and maxSequenceNumber. That might be fine though, because to manually mark something as read you must be in possession of all the relevant comments.

So I think that leaves us with:

Action	Count Modified
Fetch initial report	user starts with base count from Auth (deleted comments factored in)
New action appears from current user (report visible or not)	reset count to 0
Current user opens report (mark as read)	reset count to 0
New action appears from a different user (report visible)	reset count to 0
New action appears from a different user (report not visible)	count++ if `sequenceNumber` of new action > `lastReadSequenceNumber`
Report action deleted by another user	count-- if `sequenceNumber` of deleted action > `lastReadSequenceNumber`
Report action deleted optimistically by current user	count-- if `sequenceNumber` of deleted action > `lastReadSequenceNumber`
Report action failed to be deleted (rollback)	count++ if `sequenceNumber` of deleted action > `lastReadSequenceNumber`
Historical report action marked as unread	`maxSequenceNumber` - `lastReadSequenceNumber` - "deleted comments in range"

Not sure how to get around that last one...

cc @PauloGasparSv on this conversation too since I think they will run into this while refactoring the Edit / Delete comment stuff.

Kill reportMaxSequenceNumbers Clean up some usages getUnreadActionCOunt remove getLastReadSequenceNumber Get rid of .then() calls in Report.js Remove ambiguous `updateReportActionMessage` method Remove last .then() in Report.js Fix lastMessageText bug Dont decrement count when handling deleted comment events from current user undo random/bad change Add Math.max() Update names in ReportActionsView Clear new marker when tapping floating message counter

marcaaron · 2022-07-07T23:47:58Z

I still need to test this on other platforms besides web, but pretty happy with where this changes landed and everything is feeling more consistent and testing well. Going to open this up for some reviews now.

…Numbers

tgolen · 2022-07-08T15:43:39Z

Yeah, this feels much better and it seems like it would be much more testable. Some of the stuff in that table is maybe a little bit off. For example, "New action appears from a different user (report not visible)" mentions the sequence number of "deleted" action. I think that's not quite right? For that last use case (marking a comment as unread), it sounds very much to me like exact same case as the first one (fetch initial report). Does that help?

…

On Thu, Jul 7, 2022 at 5:48 PM Marc Glasser ***@***.***> wrote: I still need to test this on other platforms besides web, but pretty happy with where this changes landed and everything is feeling more consistent and testing well. Going to open this up for some reviews now. — Reply to this email directly, view it on GitHub <#9755 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJMAB5TTASAXQBLXWTYM73VS5UDTANCNFSM5233LPCA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

marcaaron · 2022-07-08T18:03:38Z

Some of the stuff in that table is maybe a little bit off. For example, "New
action appears from a different user (report not visible)" mentions the
sequence number of "deleted" action. I think that's not quite right?

Nice catch, that should be "new" not "deleted". Updated. Thanks!

For that last use case (marking a comment as unread), it sounds very much
to me like exact same case as the first one (fetch initial report).

Yeah, they are pretty much the same except that when we are fetching the initial report the server is the one with the knowledge of any "deleted actions" and when we are marking a comment as "unread" it's the client that knows about them.

caveat: Does seem like some of this will be changing in the future as there was a discussion here about possibly just tracking whether a report is read or unread and not the exact number of "unread" messages it has.

neil-marcellini

I have a few questions and comments, but other than that it looks really good! Thanks for cleaning this up a bit before the refactor.

src/libs/actions/Report.js

neil-marcellini

Oh cool, moment().unix() does the job.

…eNumbers

marcaaron · 2022-07-08T22:51:39Z

Hey @neil-marcellini thanks for the review!

I ended up adding a test for this in a new branch and noticed some things that were off with my code so going to do one more update here (sorry).

Luke9389

I have a few questions that will help me understand everything that's happening here.
They're pretty basic but necessary none the less.

src/libs/actions/Report.js

…nread

marcaaron · 2022-07-11T20:48:48Z

Ready for another review.

neil-marcellini

The tests are passing and the changes look good.

marcaaron · 2022-07-12T02:05:47Z

Thanks @neil-marcellini! Gonna go for the merge to avoid conflicts 🙃.

Will continue to look into improvements to the unreadActionCount stuff in this Web-Expensify PR.

OSBotify · 2022-07-12T02:11:38Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2022-07-12T21:33:41Z

🚀 Deployed to staging by @marcaaron in version: 1.1.83-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2022-07-20T22:27:17Z

🚀 Deployed to production by @chiragsalian in version: 1.1.84-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

marcaaron self-assigned this Jul 7, 2022

marcaaron mentioned this pull request Jul 7, 2022

Refactor Update Last Read #9529

Merged

89 tasks

marcaaron force-pushed the marcaaron-lastReadSequenceNumbers branch from ed52691 to e9e72f9 Compare July 7, 2022 23:39

marcaaron changed the title ~~[WIP] Clean up lastReadSequenceNumbers and reportMaxSequenceNumbers~~ Clean up lastReadSequenceNumbers and reportMaxSequenceNumbers Jul 7, 2022

marcaaron marked this pull request as ready for review July 7, 2022 23:48

marcaaron requested a review from a team as a code owner July 7, 2022 23:48

melvin-bot bot requested review from neil-marcellini and removed request for a team July 7, 2022 23:48

marcaaron requested a review from madmax330 July 7, 2022 23:48

Merge remote-tracking branch 'origin' into marcaaron-lastReadSequence…

094ac6a

…Numbers

neil-marcellini requested changes Jul 8, 2022

View reviewed changes

Default to 0 everywhere

f1669ad

marcaaron dismissed neil-marcellini’s stale review via 2fedb57 July 8, 2022 20:23

marcaaron added 2 commits July 8, 2022 10:49

adding test

454e068

Fix moment.unix()

618ca89

neil-marcellini previously approved these changes Jul 8, 2022

View reviewed changes

marcaaron added 2 commits July 8, 2022 12:49

Add test fix broken things

bcff07a

Merge branch 'marcaaron-unreadTesting' into marcaaron-lastReadSequenc…

6c0c999

…eNumbers

marcaaron dismissed neil-marcellini’s stale review via 6c0c999 July 8, 2022 22:51

marcaaron added 4 commits July 8, 2022 12:59

use indexBy

b0bac6a

DRY up test

e903cbe

fix import order

aecb8a6

update comment and test

1d9b1f4

Luke9389 reviewed Jul 8, 2022

View reviewed changes

src/libs/actions/Report.js Show resolved Hide resolved

src/libs/actions/Report.js Show resolved Hide resolved

marcaaron added 5 commits July 8, 2022 15:22

Use valueOf() not unix() for lastVisitedTimestamp

b15ed71

fix conflicts

d5be560

Update Onyx constants. Fix new marker logic when marking comment as u…

cc19522

…nread

Remove Report_UpdateLastRead

0b51cfc

command is MarkAsUnread not MarkCommentAsUnread

d721623

marcaaron requested review from neil-marcellini and Luke9389 July 11, 2022 20:48

neil-marcellini approved these changes Jul 12, 2022

View reviewed changes

marcaaron merged commit 52c2b8b into main Jul 12, 2022

marcaaron deleted the marcaaron-lastReadSequenceNumbers branch July 12, 2022 02:05

OSBotify mentioned this pull request Jul 12, 2022

Deploy Checklist: New Expensify 2022-07-12 #9847

Closed

95 tasks

marcaaron mentioned this pull request Jul 13, 2022

Fix crash when accessing bad method in ReportActionsView #9886

Merged

48 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Clean up `lastReadSequenceNumbers` and `reportMaxSequenceNumbers` #9755

Clean up `lastReadSequenceNumbers` and `reportMaxSequenceNumbers` #9755

marcaaron commented Jul 7, 2022 •

edited

Loading

marcaaron commented Jul 7, 2022

tgolen commented Jul 7, 2022

madmax330 commented Jul 7, 2022

madmax330 commented Jul 7, 2022

marcaaron commented Jul 7, 2022

madmax330 commented Jul 7, 2022

marcaaron commented Jul 7, 2022 •

edited

Loading

madmax330 commented Jul 7, 2022

marcaaron commented Jul 7, 2022

tgolen commented Jul 7, 2022

marcaaron commented Jul 7, 2022

marcaaron commented Jul 7, 2022

tgolen commented Jul 7, 2022 via email

marcaaron commented Jul 7, 2022 •

edited

Loading

marcaaron commented Jul 7, 2022

tgolen commented Jul 8, 2022 via email

marcaaron commented Jul 8, 2022

neil-marcellini left a comment

neil-marcellini left a comment

marcaaron commented Jul 8, 2022

Luke9389 left a comment

marcaaron commented Jul 11, 2022

neil-marcellini left a comment

marcaaron commented Jul 12, 2022

OSBotify commented Jul 12, 2022

OSBotify commented Jul 12, 2022

OSBotify commented Jul 20, 2022

Clean up lastReadSequenceNumbers and reportMaxSequenceNumbers #9755

Clean up lastReadSequenceNumbers and reportMaxSequenceNumbers #9755

Conversation

marcaaron commented Jul 7, 2022 • edited Loading

Details

Fixed Issues

Tests & QA

PR Review Checklist

Contributor (PR Author) Checklist

PR Reviewer Checklist

marcaaron commented Jul 7, 2022

tgolen commented Jul 7, 2022

madmax330 commented Jul 7, 2022

madmax330 commented Jul 7, 2022

marcaaron commented Jul 7, 2022

madmax330 commented Jul 7, 2022

marcaaron commented Jul 7, 2022 • edited Loading

madmax330 commented Jul 7, 2022

marcaaron commented Jul 7, 2022

tgolen commented Jul 7, 2022

marcaaron commented Jul 7, 2022

marcaaron commented Jul 7, 2022

tgolen commented Jul 7, 2022 via email

marcaaron commented Jul 7, 2022 • edited Loading

marcaaron commented Jul 7, 2022

tgolen commented Jul 8, 2022 via email

marcaaron commented Jul 8, 2022

neil-marcellini left a comment

Choose a reason for hiding this comment

neil-marcellini left a comment

Choose a reason for hiding this comment

marcaaron commented Jul 8, 2022

Luke9389 left a comment

Choose a reason for hiding this comment

marcaaron commented Jul 11, 2022

neil-marcellini left a comment

Choose a reason for hiding this comment

marcaaron commented Jul 12, 2022

OSBotify commented Jul 12, 2022

OSBotify commented Jul 12, 2022

OSBotify commented Jul 20, 2022

Clean up `lastReadSequenceNumbers` and `reportMaxSequenceNumbers` #9755

Clean up `lastReadSequenceNumbers` and `reportMaxSequenceNumbers` #9755

marcaaron commented Jul 7, 2022 •

edited

Loading

marcaaron commented Jul 7, 2022 •

edited

Loading

marcaaron commented Jul 7, 2022 •

edited

Loading