Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[No QA] Make temporary copies of moved javascript actions" #9793

Merged
merged 1 commit into from
Jul 11, 2022
Merged

Revert "[No QA] Make temporary copies of moved javascript actions" #9793

merged 1 commit into from
Jul 11, 2022

Conversation

roryabraham
Copy link
Contributor

Reverts #9784

@roryabraham roryabraham requested a review from a team as a code owner July 8, 2022 04:45
@roryabraham roryabraham self-assigned this Jul 8, 2022
@melvin-bot melvin-bot bot requested review from joelbettner and removed request for a team July 8, 2022 04:45
@roryabraham
Copy link
Contributor Author

Wait until https://github.com/Expensify/App/runs/7245607670?check_suite_focus=true is done to merge

@roryabraham
Copy link
Contributor Author

This is ready for review/merge

joelbettner
joelbettner approved these changes Jul 11, 2022
View reviewed changes
Copy link
Contributor

@joelbettner joelbettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@joelbettner joelbettner merged commit 75c0ed3 into main Jul 11, 2022
@joelbettner joelbettner deleted the revert-9784-Rory-TempFixProdDeploy branch July 11, 2022 21:43
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Jul 12, 2022
Closed
95 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @joelbettner in version: 1.1.83-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @chiragsalian in version: 1.1.84-13 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelbettner joelbettner joelbettner approved these changes

Assignees

@roryabraham roryabraham

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roryabraham @OSBotify @joelbettner