Fix broken border at edit message field #9839

thesahindia · 2022-07-12T16:40:40Z

Details

This PR fixes the broken border at edit message field.

Fixed Issues

$ #9824

Tests

Open any chat report with messages sent by you
Edit a message by long pressing/right click on the message & select 'Edit comment'
Add 2-3 lines using enter
Verify the border isn't broken

Verify that no errors appear in the JS console

PR Review Checklist

Contributor (PR Author) Checklist

PR Reviewer Checklist

The Contributor+ will copy/paste it into a new comment and complete it after the author checklist is completed

QA Steps

Open any chat report with messages sent by you
Edit a message by long pressing/right click on the message & select 'Edit comment'
Add 2-3 lines using enter
Verify the border isn't broken

Verify that no errors appear in the JS console

Screenshots

Web

Mobile Web

Desktop

iOS

Android

src/styles/styles.js

roryabraham

Code LGTM but I'll let @parasharrajat earn his C+ payment and test this out. Once he approves I'll approve and merge. 👍

src/pages/home/report/ReportActionItemMessageEdit.js

parasharrajat · 2022-07-12T18:48:45Z

src/styles/styles.js

@@ -1379,7 +1379,7 @@ const styles = {
        fontFamily: fontFamily.GTA,
        fontSize: variables.fontSizeNormal,
        borderWidth: 0,
-        borderRadius: 0,
+        borderRadius: variables.componentBorderRadiusSmall,


Also, this border radius is wrong. This also affects the composer. The composer should not have any border radius.

On the other hand, it seems that the Comment editor can have top-left and bottom-left border radius.

Hmm, it won't have any negative impact but we are going to increase the vertical margin now, so we won't need the border radius.

Visibly not but there will be. Try to match with the parent. Does corner of parent lie over the input? And is that rounded? If yes round the input corner and if not, don't round it.

After maginVertical: 6 this is how it will look, the corner won't overlap with the parent. So, we don't need the border radius.

thesahindia · 2022-07-13T20:05:00Z

Made the changes.

parasharrajat

LGTM.

cc: @roryabraham

PR Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- Any functional components have the displayName property
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

🎀 👀 🎀 C+ reviewed

OSBotify · 2022-07-20T22:25:44Z

🚀 Deployed to production by @chiragsalian in version: 1.1.84-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix the breaking of border

cdb63ea

thesahindia requested a review from a team as a code owner July 12, 2022 16:40

melvin-bot bot requested review from parasharrajat and roryabraham and removed request for a team July 12, 2022 16:40

parasharrajat reviewed Jul 12, 2022

View reviewed changes

src/styles/styles.js Outdated Show resolved Hide resolved

use variable

6b38c08

roryabraham reviewed Jul 12, 2022

View reviewed changes

roryabraham requested a review from parasharrajat July 12, 2022 18:21

parasharrajat suggested changes Jul 12, 2022

View reviewed changes

thesahindia added 2 commits July 14, 2022 01:32

increase vertical margin to match the message composer

c2ecea5

remove border radius

b55a99e

parasharrajat approved these changes Jul 14, 2022

View reviewed changes

roryabraham approved these changes Jul 14, 2022

View reviewed changes

roryabraham merged commit ae30a97 into Expensify:main Jul 14, 2022

OSBotify mentioned this pull request Jul 14, 2022

Deploy Checklist: New Expensify 2022-07-12 #9847

Closed

95 tasks

melvin-bot bot mentioned this pull request Jul 18, 2022

[HOLD for payment 2022-07-25] [$250] IOS - Edit message border broken in iOS - Reported by Santhosh-Sellavel #9824

Closed

This was referenced Aug 2, 2022

Composer text not aligned vertically centre for native app - reported by dhairyasenjaliya #10184

Closed

[HOLD for payment 2022-11-24] [$1000] Composer text and icon not aligned vertically centre for native app - reported by dhairyasenjaliya #10202

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix broken border at edit message field #9839

Fix broken border at edit message field #9839

thesahindia commented Jul 12, 2022

roryabraham left a comment

parasharrajat Jul 12, 2022

thesahindia Jul 12, 2022

parasharrajat Jul 12, 2022 •

edited

Loading

thesahindia Jul 13, 2022

thesahindia commented Jul 13, 2022

parasharrajat left a comment

OSBotify commented Jul 20, 2022

Fix broken border at edit message field #9839

Fix broken border at edit message field #9839

Conversation

thesahindia commented Jul 12, 2022

Details

Fixed Issues

Tests

PR Review Checklist

Contributor (PR Author) Checklist

PR Reviewer Checklist

QA Steps

Screenshots

Web

Mobile Web

Desktop

iOS

Android

roryabraham left a comment

Choose a reason for hiding this comment

parasharrajat Jul 12, 2022

Choose a reason for hiding this comment

thesahindia Jul 12, 2022

Choose a reason for hiding this comment

parasharrajat Jul 12, 2022 • edited Loading

Choose a reason for hiding this comment

thesahindia Jul 13, 2022

Choose a reason for hiding this comment

thesahindia commented Jul 13, 2022

parasharrajat left a comment

Choose a reason for hiding this comment

PR Reviewer Checklist

OSBotify commented Jul 20, 2022

parasharrajat Jul 12, 2022 •

edited

Loading