Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] Change job condition to string comparision #9870

Merged
merged 1 commit into from
Jul 12, 2022

Conversation

roryabraham
Copy link
Contributor

Details

Following-up on #9812, still trying to get it working.

Fixed Issues

$ n/a

Tests

Merge and pray

@roryabraham roryabraham self-assigned this Jul 12, 2022
@roryabraham roryabraham requested a review from a team as a code owner July 12, 2022 23:45
@melvin-bot melvin-bot bot requested review from PauloGasparSv and removed request for a team July 12, 2022 23:46
@roryabraham
Copy link
Contributor Author

roryabraham commented Jul 12, 2022

Going to skip tests for urgency here. Deploys are broken

@roryabraham roryabraham merged commit 578d96e into main Jul 12, 2022
@roryabraham roryabraham deleted the Rory-FixPreDeploy branch July 12, 2022 23:48
@melvin-bot
Copy link

melvin-bot bot commented Jul 12, 2022

@roryabraham looks like this was merged without passing tests. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @chiragsalian in version: 1.1.84-13 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants