feat: enable no-invalid-this #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>
|
No reviewers, No Assignees. Feels like a desert 🏜️ . Where is everybody |
s77rt
suggested changes
Apr 26, 2023
rules/es6.js
Outdated
| @@ -23,5 +23,7 @@ module.exports = { | |||
| // Do not use these features yet | |||
| 'es/no-nullish-coalescing-operators': 'error', | |||
| 'es/no-optional-chaining': 'error', | |||
|
|
|||
| 'no-invalid-this': 'error' | |||
There was a problem hiding this comment.
Suggested change
| 'no-invalid-this': 'error' | |
| 'no-invalid-this': 'error', |
This will fail on lint 😅
Can you also add a comment here?
There was a problem hiding this comment.
@s77rt updated!
This was referenced Apr 26, 2023
Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>
Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>
s77rt
approved these changes
Apr 26, 2023
tgolen
approved these changes
Apr 26, 2023
|
All right, this is published to npm now: eslint-config-expensify@2.0.36 |
|
Thank you for the super quick deployment @tgolen! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: Expensify/App#17971