Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update QBD Sync Manager version #337

Merged
merged 1 commit into from
Feb 25, 2021
Merged

Update QBD Sync Manager version #337

merged 1 commit into from
Feb 25, 2021

Conversation

francoisl
Copy link
Contributor

@francoisl francoisl commented Feb 23, 2021 •
edited
Loading

Pullerbear review (@thienlnam)

Fixed Issues

Needed for https://github.com/Expensify/Expensify/issues/150106

Tests/QA

Will only be testable on Web-E after updating it to use the latest expensify-common, but here are the steps:

  1. Create a new policy
  2. Go to Connections > QuickBooks Desktop, expand the section
  3. Click on the "Need to reinstall the Sync Manager? Click here" link
  4. Make sure something downloads

image

@francoisl francoisl requested a review from a team February 23, 2021 22:50
@francoisl francoisl self-assigned this Feb 23, 2021
@botify botify requested review from thienlnam and removed request for a team February 23, 2021 22:51
@github-actions
Copy link

github-actions bot commented Feb 23, 2021 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@francoisl
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

thienlnam
thienlnam approved these changes Feb 25, 2021
View reviewed changes
Copy link
Contributor

@thienlnam thienlnam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@thienlnam thienlnam merged commit 9254b61 into master Feb 25, 2021
@thienlnam thienlnam deleted the francoisUpdateQbdSyncManager branch February 25, 2021 17:35
@github-actions github-actions bot locked and limited conversation to collaborators Feb 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thienlnam thienlnam thienlnam approved these changes

Assignees

@francoisl francoisl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@francoisl @thienlnam