-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow more lenient code fencing with new lines #376
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems to check out 👍
I'm going to tap the resident regexer @timszot to double check me though (I'm 🤞 that he also has his android dot cash environment set up properly to test as well)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My android e.cash dev setup is also not working, but with the added tests here this looks good to me.
Details
Our code fencing previously only worked if there were newlines surrounding the wrapped text. This changes it so that you don't need newlines (just like what Slack offers). See the issue for more context.
e.g:
```
hi
```
and ```hi``` are the same.
Fixed Issues
$ Expensify/App#3039
Tests
QA
In Expensify.cash, try to send this as a message, and verify it renders the same as the screenshot:
Screen Captures
Web
2021-05-24_19-20-04.mp4
Mobile Web
2021-05-24_19-42-48.mp4
iOS
2021-05-24_19-40-34.mp4
Android
1621913590738637.mp4
Desktop
2021-05-24_19-23-36.mp4