fixed url parsing for escaped chars #396
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anyone, will you please review this?
[Explanation of the change or anything fishy that is going on]
We escape the input string before apply Rules from Expensimark but we forgot to check for the Escaped chars in the URL regex. I have updated that.
Apart from it, Added
:
to the regex so that it can be matched as part of the URL. Google Map URLs contain this.Fixed Issues
$ Expensify/App#4105
Tests
Unit test
I tried many URLs for matching and all seem to pass
QA
URLs should be parsed in E.cash.
E.cash messaging