Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed url parsing for escaped chars #396

Merged
merged 1 commit into from
Jul 20, 2021

Conversation

parasharrajat
Copy link
Member

@parasharrajat parasharrajat commented Jul 20, 2021

Anyone, will you please review this?

[Explanation of the change or anything fishy that is going on]
We escape the input string before apply Rules from Expensimark but we forgot to check for the Escaped chars in the URL regex. I have updated that.
Apart from it, Added : to the regex so that it can be matched as part of the URL. Google Map URLs contain this.

Fixed Issues

$ Expensify/App#4105

Tests

  1. What unit/integration tests cover your change? What autoQA tests cover your change?
    Unit test
  2. What tests did you perform that validates your changed worked?
    I tried many URLs for matching and all seem to pass

QA

  1. What does QA need to do to validate your changes?
    URLs should be parsed in E.cash.
  2. What areas to they need to test for regressions?
    E.cash messaging

@parasharrajat
Copy link
Member Author

@Jag96 Requesting review. Thanks.

@tgolen tgolen merged commit 7d8408c into Expensify:master Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants