Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL PATH REGEX improved to match any link #426

Merged
merged 2 commits into from
Nov 16, 2021

Conversation

mateusbra
Copy link
Contributor

Changing URL regex in order to match when link have a special charactere such as ( . , = ( + $ ! * ) right before a /

Fixed Issues

#6216

Tests

  1. Enter the chat.
  2. Type any URL.
  3. Verify the URL is autolinked.

Screenshot

WhatsApp Image 2021-11-06 at 02 05 01

QA

  1. Enter the chat any URL(specially with special charactere before a /), it must match with the new regex and be autolinked.

@mateusbra mateusbra requested a review from a team as a code owner November 12, 2021 17:04
@MelvinBot MelvinBot requested review from pecanoro and removed request for a team November 12, 2021 17:05
@mateusbra
Copy link
Contributor Author

I had to change a little bit the regex in order to have a . or , in the end of an URL like:
https://test.com. <--- . in the end not included in the link, also, i've added an unit test.

Now I think its ok for merging, just need your approval @pecanoro

@pecanoro pecanoro merged commit fa190f6 into Expensify:main Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants