Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra line under codeblock #435

Merged

Conversation

sobitneupane
Copy link
Contributor

@Beamanator @rushatgabhane will you please review this?

Code block is wrapped by <pre> </pre> tags. And When new line is added <br /> tag is also added. So, In turn, </pre> <br /> tags get added in the html.
Here, </pre> tag changes the line and <br /> add another line. So there is extra line.

Fixed Issues

$ Expensify/App#7496

Tests

  1. Send some code blocks in chat like

    Here is come code

    const myLineOfCode = 'some code';
    

    And that was my code!

  2. There should not be an extra line below the codeblock.

QA

  1. Send some code blocks in chat like

    Here is come code

    const myLineOfCode = 'some code';
    

    And that was my code!

  2. There should not be an extra line below the codeblock.

Screenshots

Web

Screen Shot 2022-02-10 at 18 04 02

Desktop

Screen Shot 2022-02-10 at 19 50 24

Android

IOS

mWeb

@sobitneupane sobitneupane requested a review from a team as a code owner February 10, 2022 15:29
@MelvinBot MelvinBot requested review from nkuoch and removed request for a team February 10, 2022 15:29
@sobitneupane
Copy link
Contributor Author

Found this issue while working on this PR https://expensify.slack.com/archives/C01GTK53T8Q/p1644507497800049

@nkuoch nkuoch merged commit f77bb47 into Expensify:main Feb 10, 2022
@rushatgabhane
Copy link
Member

This change will be deployed to Expensify/App in the above PR (7700)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants