Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blockquotes limiting in ExpensiMark #665

Conversation

Skalakid
Copy link
Contributor

@Skalakid Skalakid commented Mar 13, 2024

This PR fix blockquote limiting bug that appears when pasting more than 3 > and text after them. ExpensiMark on first parsing returns 4 blockquotes instead of 3 (limit is 3)

fix.mov

Fixed Issues

$ Expensify/App#36227

Tests

  1. Open New Dot App on native devices
  2. Write inside the Composer >>>> Test
  3. Input should show only 3 blockquotes
  4. Send the message
  5. Verify if sent message has only 3 blockquotes

QA

Verify if with this changes bug is fixed on all native platforms or on the web live markdown PR

@Skalakid Skalakid marked this pull request as ready for review March 13, 2024 12:49
@Skalakid Skalakid requested a review from a team as a code owner March 13, 2024 12:49
@melvin-bot melvin-bot bot requested review from blimpich and removed request for a team March 13, 2024 12:49
@blimpich blimpich merged commit dc8ea98 into Expensify:main Mar 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants