Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bold markdown display incorrectly #681

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

tienifr
Copy link
Contributor

@tienifr tienifr commented Apr 10, 2024

Fixed Issues

$ Issue: Expensify/App#38522
$ Proposal: Expensify/App#38522 (comment)

Tests

  1. What unit/integration tests cover your change? What autoQA tests cover your change?
  2. What tests did you perform that validates your changed worked?

QA

  1. Open any report
  2. Compose a multiline message with bold and codeblock:
bold
```*not a bold*```
This is *bold* 
  1. Should render
    bold
    *not a bold*
    This is bold

Screenshots/Videos

Android: Native
Screen.Recording.2024-04-10.at.18.40.29.mov
Android: mWeb Chrome
Screen.Recording.2024-04-10.at.18.42.30.mov
iOS: Native
  • I encountered an issue with my ios native device. Will update ASAP
iOS: mWeb Safari
Screen.Recording.2024-04-10.at.18.44.29.mov
MacOS: Chrome / Safari
Screen.Recording.2024-04-10.at.18.28.25.mov
MacOS: Desktop
Screen.Recording.2024-04-10.at.18.36.19.mov

Copy link
Contributor

@hayata-suenaga hayata-suenaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢

@hayata-suenaga hayata-suenaga merged commit c2df007 into Expensify:main Apr 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants