Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add static logger to ExpensiMark #712

Merged

Conversation

blazejkustra
Copy link
Contributor

@blazejkustra blazejkustra commented Jun 3, 2024

Currently using Log.alert in ExpensiMark causes E/App to crash, to avoid this we want to add possibility to set your own logger in ExpensiMark and provide errorless default logger that just console.warns.

Fixed Issues

$ Expensify/App#42161

@blazejkustra blazejkustra marked this pull request as ready for review June 4, 2024 09:05
@blazejkustra blazejkustra requested a review from a team as a code owner June 4, 2024 09:05
@melvin-bot melvin-bot bot requested review from francoisl and removed request for a team June 4, 2024 09:05
@war-in war-in mentioned this pull request Jun 4, 2024
@francoisl francoisl merged commit 43d1bf3 into Expensify:main Jun 4, 2024
6 checks passed
Copy link

github-actions bot commented Jun 4, 2024

🚀Published to npm in v2.0.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants