-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix autolink isn't recognized when put before img markdown #782
Fix autolink isn't recognized when put before img markdown #782
Conversation
I'm not sure how can we test this visually, but if we convert
using the ExpensiMark, the result is
|
Looks like changing |
thanks @danieldoglas! @getusha do you want to go through the testing on this one? I'm still seeing the bug but I might have incorrectly linked the module, so I'll try again in a bit |
It's working fine for me Screen.Recording.2024-08-16.at.1.14.11.in.the.afternoon.movI'll test it on native as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay finally got this to work. Looks good to me! Can we also please double check that we're not reintroducing #661 (comment) ? Thanks!
oh i missed that. Okay great! (side note: do we not show alt text of images? It's not showing up for me.) |
🚀Published to npm in v2.0.76 |
Fixed Issues
$ Expensify/App#46491
Tests
What unit/integration tests cover your change? What autoQA tests cover your change?
A unit test is updated
What tests did you perform that validates your changed worked?
To be able to test the live markdown, update the regex in
node_modules/@expensify/react-native-live-markdown/lib/parser/react-native-live-markdown-parser.js
Android: Native
android.mp4
Android: mWeb Chrome
android.mweb.mp4
iOS: Native
ios.mp4
iOS: mWeb Safari
ios.mweb.mp4
MacOS: Chrome / Safari
web.mp4
MacOS: Desktop
desktop.mp4
QA
Same as Tests
Same as Tests