Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/22998 - Init package #1

Merged
merged 34 commits into from
Aug 17, 2023

Conversation

rezkiy37
Copy link
Contributor

@rezkiy37 rezkiy37 commented Jul 31, 2023

Details

This is a base PR for a public package - react-fast-pdf. The goal here to have fundament configurations.
Since, it is a package, it includes 2 "projects". I mean the main part ./src and the example ./example/**. I used Expensify/react-native-x-maps like a template.

Note: In the future for the example, we should update link to react-fast-pdf in ./example/package.json. Right now it uses fork branch to use current changes.

Related Issues

Expensify/App#22998, Expensify/App#19918

Manual Tests

  1. Run npm install at the root.
  2. Run npm install at the example directory.
  3. Test all scripts in both package.json.

Linked PRs

N/A

@rezkiy37 rezkiy37 force-pushed the feature/22998-pdf-preview-library branch from dcffbae to 56a4e39 Compare August 8, 2023 19:22
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@allroundexperts
Copy link

I don't see any checks running @rezkiy37. Do we need to do something in order to trigger those?

@rezkiy37
Copy link
Contributor Author

I don't see any checks running @rezkiy37. Do we need to do something in order to trigger those?

@allroundexperts, I can confirm that it triggers workflows, but on my fork. AFAIK, once we have workflows in the main repo, it is visible in PRs.

Screenshot 2023-08-16 at 13 43 45

Also, about "CLA Assistant" (cla.yml), we should configure GH secrets. How and who can do it, @allroundexperts?

@allroundexperts
Copy link

Someone from our internal team would need to do that.

@rezkiy37
Copy link
Contributor Author

Someone from our internal team would need to do that.

Do you know someone who can help us?

@allroundexperts
Copy link

Also, about "CLA Assistant" (cla.yml), we should configure GH secrets.

@nathanmetcalf @AndrewGable Can someone please help?

@AndrewGable
Copy link
Contributor

It's set up as an org level secret, so you are good to go once it's merged 👍

@rezkiy37
Copy link
Contributor Author

@allroundexperts, seems like all this CI jobs work once this PR has been merged. Any other blockers for review?

Copy link

@allroundexperts allroundexperts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@allroundexperts
Copy link

@allroundexperts, seems like all this CI jobs work once this PR has been merged. Any other blockers for review?

Not really, the initial code looks fine!

@AndrewGable AndrewGable merged commit 4efcbe3 into Expensify:main Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants