-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/22998 - Init package #1
Feature/22998 - Init package #1
Conversation
dcffbae
to
56a4e39
Compare
I don't see any checks running @rezkiy37. Do we need to do something in order to trigger those? |
@allroundexperts, I can confirm that it triggers workflows, but on my fork. AFAIK, once we have workflows in the main repo, it is visible in PRs. ![]() Also, about "CLA Assistant" ( |
Someone from our internal team would need to do that. |
Do you know someone who can help us? |
@nathanmetcalf @AndrewGable Can someone please help? |
It's set up as an org level secret, so you are good to go once it's merged 👍 |
@allroundexperts, seems like all this CI jobs work once this PR has been merged. Any other blockers for review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Not really, the initial code looks fine! |
Details
This is a base PR for a public package -
react-fast-pdf
. The goal here to have fundament configurations.Since, it is a package, it includes 2 "projects". I mean the main part
./src
and the example./example/**
. I used Expensify/react-native-x-maps like a template.Note: In the future for the example, we should update link to
react-fast-pdf
in./example/package.json
. Right now it uses fork branch to use current changes.Related Issues
Expensify/App#22998, Expensify/App#19918
Manual Tests
npm install
at the root.npm install
at theexample
directory.package.json
.Linked PRs
N/A