-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PDF preview component #2
PDF preview component #2
Conversation
…o feature/22998-pdf-preview-component
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA. |
By the way, I've tried to connect the package to the Expensify (NewDot) app. It works. Chrome.mp4Desktop.mp4 |
@rezkiy37 Has this approach merging |
@allroundexperts, we had a discussing about it in the issue. |
@allroundexperts, how can we move forward? |
@rezkiy37 Do we have any issue to track the publishing of this package to npm? |
Who can help us from the Expensify team with access to their NPM? |
I think its the infra team. Would be best to ask in the open source channel. |
Tested and confirmed that its working well! Screen.Recording.2023-11-06.at.11.10.36.PM.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests well!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I can move it ahead and hopefully we can get the npm setup here soon
Details
This is a PR where we introduce a MVP version of
react-fast-pdf
package. The package codebase itself has a basic configuration to read and preview a PDF file. Theexample
has a basic template how to use the package.Related Issues
Expensify/App#22998
Manual Tests
npm install && cd example && npm install && cd ..
.cd example && npm run start && cd ..
- of the example.Linked PRs
N/A
PDF.mp4